Fix namespace conflicts and snap compatibility in deployment pipeline#5
Open
motangpuar wants to merge 1 commit intoo-ran-sc:masterfrom
Open
Fix namespace conflicts and snap compatibility in deployment pipeline#5motangpuar wants to merge 1 commit intoo-ran-sc:masterfrom
motangpuar wants to merge 1 commit intoo-ran-sc:masterfrom
Conversation
Contributor
|
Hi @motangpuar Unfortunately, this Github version of IT/DEP is a read-only mirror of the repo maintained in O-RAN SC Gerrit https://gerrit.o-ran-sc.org/r/q/project:it/dep Meanwhile, we will have a look at your suggestions. |
Author
|
Thank you @JohnKeeneyEST I'll try to push the review on gerrit |
9a802e9 to
8a92b23
Compare
- Replace `helm install` to `helm upgrade --install` (proceed when ns exist) - Install `yq` by download the binary instead of snap (no snap in container) - Jenkins pipeline env.REPO Change-Id: I346617ee9f593d16a9afcd5bbce397005899ee30 Signed-off-by: ymarselino <m11202819@gapps.ntust.edu.tw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helm installtohelm upgrade --install, so these scriptswon't stop upon finding that the namespace exists
of ubuntu (Test on K8S jenkins->k8s pipeline)
test my own fork instead of yours)
Tried to request for code review through gerrit, but I got 403.
My gerrit account name is
ymarselino(m11202819@gapps.ntust.edu.tw) affiliated with OSC Lab Taiwan (NTUST)