Removed LogicalTime class and usages #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monix.Coeval => cats.Eval
3803: Fix of sync issue when block is received but not added to DAG r=stanislavlyalin a=stanislavlyalin Co-authored-by: stanislavlyalin <lyalinstas@gmail.com>
Remove custom code copied from monix
Update scalapb version
nzpr
force-pushed
the
CE
branch
9 times, most recently
from
0cdece7 to
84f0f5f
Compare
nzpr
force-pushed
the
CE
branch
15 times, most recently
from
1de7a2c to
55fbebb
Compare
nzpr
force-pushed
the
CE
branch
9 times, most recently
from
892acae to
a5030fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Completely removed the LogicalTime class and its usage. TestControl is not needed, since the methods from LogicalTime were not used or were trivial and easily replaced by normal code.
Please make sure that this PR:
Bors cheat-sheet:
bors r+runs integration tests and merges the PR (if it's approved),bors tryruns integration tests for the PR,bors delegate+enables non-maintainer PR authors to run the above.