Open
Conversation
Author
|
Note: this simply makes make-deb run on Python3, not package Py3 project properly. |
Contributor
|
This commit breaks Python 2 compatibility. Python 2 defines the input() function to eval what the user inputs; whereas raw_input just returns the string. |
|
Looks like a lot of these changes have been done already. This can be closed I think. |
Daenyth
suggested changes
Feb 23, 2017
| debconf.render() | ||
| except DebianConfigurationException as e: | ||
| print e | ||
| print(e) |
There was a problem hiding this comment.
You need to add from __future__ import print_function as the first line, otherwise this can have surprising behavior when modified.
| for name, value in zip(setup_names, setup_values): | ||
| while not value or value == UNKNOWN: | ||
| value = raw_input( | ||
| value = input( |
There was a problem hiding this comment.
This isn't safe for python2, input on python2 is eval(raw_input())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the changes I needed to make to run this in a Python3 venv. Feel free to reject if you want to stay Python 2.