Fix segfault in sample.c due to analigned access caused by strcpy #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strcpy calls in sample.c caused segmentation fault on kernels with CONFIG_FORTIFY_SOURCE enabled. This occurs because strcpy is compiled as a memcpy (preceded by a strlen), which violates memory alignment constraints and lead to a crash. To resolve the issue, all strcpy calls in sample.c were replaced with a byte-by-byte copy, ensuring that no unaligned access occurs. Tested on both kernels with and without CONFIG_FORTIFY_SOURCE to ensure compatibility and to confirm that the changes prevent the segfault. Signed-off-by: Massimiliano Pellizzer <massimiliano.pellizzer@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strcpy calls in sample.c caused segmentation fault on kernels with CONFIG_FORTIFY_SOURCE enabled. This occurs because strcpy is compiled as a memcpy (preceded by a strlen), which violates memory alignment constraints and lead to a crash.
To resolve the issue, all strcpy calls in sample.c were replaced with a byte-by-byte copy, ensuring that no unaligned access occurs.
Tested on both kernels with and without CONFIG_FORTIFY_SOURCE to ensure compatibility and to confirm that the changes prevent the segfault.