Skip to content

Fix isOfLegalAge query issues #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErpingS merged 2 commits into from
Nov 14, 2025
Merged

Fix isOfLegalAge query issues #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddae3d5
fix
tdanielles Nov 14, 2025
3204fa4
fix
tdanielles Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/firebase/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export interface Applicant {
gender: string | Record<string, boolean>;
graduation: number;
isOfLegalAge: boolean;
ageByHackathon: string;
location: string; // city
major: ApplicantMajor | Record<string, boolean>;
phoneNumber: string; // "+1 XXX-XXX-XXXX"
Expand Down
12 changes: 11 additions & 1 deletion src/services/query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ export const flattenApplicantData = (applicant: Applicant, hackathon?: string):
const hackathonYear = year ? Number.parseInt(year) : 2025;
const isLegacyFormat = hackathonYear < 2024 || hackathon === "nwHacks2024";

const computedIsOfLegalAge = (applicant: Applicant) => {
const rawAge = applicant.basicInfo?.ageByHackathon
if (rawAge == "<=16") return false
if (rawAge == ">24") return true

const numericAge = typeof rawAge === "number" ? rawAge : Number(rawAge)
return numericAge >= 19
}

const flattened: FlattenedApplicant = {
// Basic Info
firstName: applicant.basicInfo?.legalFirstName || applicant.basicInfo?.firstName || "",
Expand All @@ -55,7 +64,7 @@ export const flattenApplicantData = (applicant: Applicant, hackathon?: string):
applicant.basicInfo?.gender as Record<string, boolean> | undefined,
''
),
isOfLegalAge: applicant.basicInfo?.isOfLegalAge || false,
isOfLegalAge: computedIsOfLegalAge(applicant),
culturalBackground: returnTrueKey(applicant.basicInfo?.ethnicity || applicant.basicInfo?.culturalBackground),
dietaryRestriction: createStringFromSelection(
applicant.basicInfo?.dietaryRestriction,
Expand Down Expand Up @@ -148,6 +157,7 @@ export const getAvailableColumns = (): string[] => {
gender: "",
location: "",
isOfLegalAge: true,
ageByHackathon: "0",
ethnicity: {
asian: false,
black: false,
Expand Down