Enable privacy notification tray for screen sharing#165
Open
Enable privacy notification tray for screen sharing#165
Conversation
Update desktop_capture_devices_util.cc
Contributor
|
Just want to clarify that screen sharing was already working and this PR fixes and enables the stop sharing button which was previously missing? |
Contributor
|
@rogerwang requesting your review, forgot to ping you here |
hthetiot
reviewed
Jan 14, 2026
| #endif | ||
| std::unique_ptr<content::MediaStreamUI> ui; | ||
| return ui; | ||
|
|
There was a problem hiding this comment.
I think you need to keep the return ui, or if not let's keep "#if 0" so up stream merge is easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed bug: nwjs/nw.js#8156
To enable screen-sharing, these patches need to be undone.