Make tests Windows compatible #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gege-hoho
force-pushed
the
feature/fix_test_for_windows
branch
from
19a4dd7 to
7655bf2
Compare
nwilbert
requested changes
Feb 6, 2023
Comment on lines
+22
to
+24
| drive = '' | ||
| if arch_project_paths[1].drive: | ||
| drive = arch_project_paths[1].drive |
Owner
There was a problem hiding this comment.
I think you can replace this with just drive = arch_project_paths[1].drive?
On non-Windows systems drive should be an empty string.
Comment on lines
+49
to
+51
| drive = '' | ||
| if arch_project_paths[1].drive: | ||
| drive = arch_project_paths[1].drive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were not working on Windows due to the Path Structure