Skip to content

Fix the Context::getCompatibleDevices() method, to skip the CPU devic… #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Frederique-Hsu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the Context::getCompatibleDevices() method, to skip the CPU devic… #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions nvvk/context_vk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,6 +1061,18 @@ std::vector<uint32_t> Context::getCompatibleDevices(const ContextCreateInfo& inf
if(info.verboseCompatibleDevices)
LOGI("%d: %s\n", elemId, props.deviceName);

/*!
* \bug Since the getDeviceExtensions() will return all extensions, when passing an argument of CPU device.
* Hence we have to skip the CPU-type device.
* Especially, when user wants to enable the "VK_KHR_ray_tracing_pipeline" extension, it will return a
* wrong compatible device to user, provided that not skip the CPU type.
*/
if (props.deviceType == VK_PHYSICAL_DEVICE_TYPE_OTHER || props.deviceType == VK_PHYSICAL_DEVICE_TYPE_CPU)
{
LOGI(" - this device is of CPU type\n");
continue;
}

// Check if the device has all the requested extensions
const std::vector<VkExtensionProperties> extensionProperties = getDeviceExtensions(physicalDevice);
const std::vector<std::string> missingExtensions = checkEntryArray(extensionProperties, info.deviceExtensions);
Expand Down