Open
Conversation
Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com>
Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com>
Contributor
|
@jmayank1511 to review as well |
Contributor
|
@styagi130 can we add magpie instructions to the README for users to refer? |
Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com>
nemo2riva/cookbook.py
Outdated
| export_file = os.path.join(tmpdir, export_filename) | ||
|
|
||
| if cfg.export_format in ["ONNX", "TS"]: | ||
| if cfg.export_format in ["ONNX", "TS"] and (model.__class__.__name__ == "MagpieTTSModel" and args.submodel == "encoder"): |
requirements.txt
Outdated
| nvidia-eff-tao-encryption>=0.1.8 | ||
| nvidia-pyindex==1.0.6 | ||
| onnx==1.18.0 | ||
| onnx==1.16.0 |
Contributor
There was a problem hiding this comment.
@styagi130 to update to not change onnx version requirements, so as not to disturb ASR.
Author
There was a problem hiding this comment.
Moved onnx version==1.18.0 in the latest commit.
Contributor
|
also, @styagi130 let's rebase this |
Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com>
jasro23
reviewed
Sep 16, 2025
| # "path_type": "TAR_PATH", | ||
| # "content": artifact_content, | ||
| #} | ||
| #f.close() |
There was a problem hiding this comment.
can we remove this code block if commented and use context manager for file operation
Contributor
There was a problem hiding this comment.
@styagi130 could you review this comment and update as needed?
Contributor
|
@jmayank1511 does this look fine from ASR perspective? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.