Open
Conversation
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
anand-nv
force-pushed
the
canary_support
branch
from
00179a4 to
f262588
Compare
anand-nv
requested review from
atomer-nvidia and
rmittal-github
and removed request for
rmittal-github
atomer-nvidia
approved these changes
Nov 11, 2024
| schema_dict = None | ||
|
|
||
| supported_formats = ["ONNX", "CKPT", "TS", "NEMO"] | ||
| supported_formats = ["ONNX", "CKPT", "TS", "NEMO", "PYTORCH", "STATE"] |
Contributor
There was a problem hiding this comment.
do we need to add separate "PYTORCH" as supported format or can we use "CKPT" for it?
Author
There was a problem hiding this comment.
PYTORCH in case we are just exporting part of the model or tensors.
requirements.txt
Outdated
| nvidia-eff-tao-encryption>=0.1.8 | ||
| nvidia-pyindex==1.0.6 | ||
| onnx==1.14.1 | ||
| onnx==1.16.1 |
Contributor
There was a problem hiding this comment.
would the same versions as Riva container work here?
torch 2.5.0
onnx 1.17.0
will be good them same to avoid any possible discrepancies due to version mismatches b/w nemo and Riva.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for canary models