Fix for User/Group Creation Issue #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for User/Group Creation Bug
The script sometimes failed when attempting to re-create the host user (e.g., ubuntu with UID 1000) inside the container.
Problem: The userdel "$DOCKER_RUN_USER_NAME" command, intended for cleanup, occasionally deleted the corresponding primary group ($DOCKER_RUN_GROUP_NAME) if the user was its sole member. This caused the subsequent useradd command to fail with useradd: group 'ubuntu' does not exist.
Fix: A necessary, idempotent groupadd --force call is re-inserted immediately after the userdel operation. This ensures the target group is immediately restored and confirmed to exist just before the final useradd attempt.