feat(machine): smart prompt defaults for machine config by nvandessel · Pull Request #106 · nvandessel/go4dot

nvandessel · 2026-02-28T01:17:25Z

Summary

Add resolveDefaults() to enrich machine config prompts with auto-detected values
user_name and user_email default from git config --global
signing_key converts to select dropdown when GPG keys are detected (with "None" and "Enter manually..." options)
Post-processing extracts key IDs from formatted select values
Returns a copy — never mutates input prompts

Depends on: #PR1 (feat/ssh-keygen-wizard)

Test plan

make build && make lint && make test passes
Verify defaults populated from git config
Verify existing non-empty defaults are NOT overwritten
Verify original prompts not mutated (copy semantics)

🤖 Generated with Claude Code

coderabbitai · 2026-02-28T01:17:32Z

Warning

Rate limit exceeded

@nvandessel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 71e97e4 and 20a069a.

📒 Files selected for processing (2)

internal/machine/prompts.go
internal/machine/prompts_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/smart-prompt-defaults

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-02-28T01:20:47Z

Greptile Summary

Adds smart prompt defaults for machine config by auto-detecting git user info and GPG keys. The resolveDefaults() function enriches prompts with values from git config --global and converts signing_key to a select dropdown when GPG keys are detected.

Key changes:

user_name and user_email auto-populate from git config if empty
signing_key becomes a select dropdown with detected GPG keys plus "None" and "Enter manually..." options
Post-processing extracts key IDs from formatted select values
Returns a copy with proper slice allocation for Prompts, original not mutated
Comprehensive test coverage for default resolution and copy semantics

Previous threads raised valid points:

Test should verify Options slice independence for complete copy semantics validation
Format "%s — %s" differs from existing FormatGPGKeyChoice() which uses "%s <%s> (%s)" - consider consistency

Confidence Score: 4/5

Safe to merge with minor recommendations from previous threads
Implementation is functionally correct with proper copy semantics for the main use case. Previous threads identified two valid but non-blocking improvements: Options slice independence test and format consistency with existing helper.
No files require special attention - previous thread comments address the minor improvements needed

Important Files Changed

Filename	Overview
internal/machine/prompts.go	Adds `resolveDefaults()` to auto-populate git config and GPG keys. Copy semantics are mostly correct, format differs from existing `FormatGPGKeyChoice()` helper.
internal/machine/prompts_test.go	Adds comprehensive tests for `resolveDefaults()`. Previous thread correctly notes test should verify `Options` slice independence.

_{Last reviewed commit: 20a069a}

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-28T01:20:51Z

internal/machine/prompts_test.go

+func TestResolveDefaults_NoCopy(t *testing.T) {
+	// Verify original prompts are not mutated
+	original := config.MachinePrompt{
+		ID: "test",
+		Prompts: []config.PromptField{
+			{ID: "user_name", Default: ""},
+		},
+	}
+	_ = resolveDefaults(original)
+	if original.Prompts[0].Default != "" {
+		t.Error("original prompts were mutated")
+	}
+}


Test should also verify Options slice independence to ensure complete copy semantics. Add check like:

Suggested change

func TestResolveDefaults_NoCopy(t *testing.T) {

// Verify original prompts are not mutated

original := config.MachinePrompt{

ID: "test",

Prompts: []config.PromptField{

{ID: "user_name", Default: ""},

},

}

_ = resolveDefaults(original)

if original.Prompts[0].Default != "" {

t.Error("original prompts were mutated")

}

}

func TestResolveDefaults_NoCopy(t *testing.T) {

// Verify original prompts are not mutated

original := config.MachinePrompt{

ID: "test",

Prompts: []config.PromptField{

{ID: "user_name", Default: "", Options: []string{"a", "b"}},

},

}

result := resolveDefaults(original)

if original.Prompts[0].Default != "" {

t.Error("original prompts were mutated")

}

// Verify Options slice is independent (if modified)

if len(original.Prompts[0].Options) != 2 {

t.Error("original Options slice was modified")

}

}

greptile-apps · 2026-02-28T01:20:52Z

internal/machine/prompts.go

+				p.Type = "select"
+				p.Options = []string{"None"}
+				for _, k := range keys {
+					p.Options = append(p.Options, fmt.Sprintf("%s — %s", k.KeyID, k.Email))


Format differs from FormatGPGKeyChoice() in git.go (line 291-293) which uses "%s <%s> (%s)". Consider using the existing formatter for consistency, or document why different formats are needed.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

nvandessel · 2026-02-28T01:28:18Z

🌴 Frond Stack

main
└── feat/ssh-keygen-wizard  #104  [ready]
    ├── feat/gh-key-registration  #105  [blocked: ssh-keygen-wizard]
    │   └── feat/setup-verification  #107  [blocked: gh-key-registration, smart-prompt-defaults]
    └── feat/smart-prompt-defaults  #106  👈  [blocked: ssh-keygen-wizard]

Managed by frond

Add resolveDefaults() to enrich prompts with auto-detected values: - user_name defaults from git config --global user.name - user_email defaults from git config --global user.email - signing_key converts to select dropdown when GPG keys detected (with "None" and "Enter manually..." options) - Post-processing extracts key IDs from formatted select values - Returns a copy, never mutates input prompts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nvandessel · 2026-02-28T18:30:22Z

@greptileai review

codecov · 2026-02-28T18:31:55Z

Codecov Report

❌ Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.70%. Comparing base (71e97e4) to head (20a069a).

Files with missing lines	Patch %	Lines
internal/machine/prompts.go	52.94%	16 Missing ⚠️

❌ Your patch check has failed because the patch coverage (52.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   48.68%   48.70%   +0.01%     
==========================================
  Files         108      108              
  Lines       12059    12092      +33     
==========================================
+ Hits         5871     5889      +18     
- Misses       6188     6203      +15

Files with missing lines	Coverage Δ
internal/machine/prompts.go	`51.33% <52.94%> (+0.90%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

greptile-apps bot reviewed Feb 28, 2026

View reviewed changes

Base automatically changed from feat/ssh-keygen-wizard to main February 28, 2026 18:28

nvandessel force-pushed the feat/smart-prompt-defaults branch from c8ad870 to 20a069a Compare February 28, 2026 18:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(machine): smart prompt defaults for machine config#106

feat(machine): smart prompt defaults for machine config#106
nvandessel wants to merge 1 commit intomainfrom
feat/smart-prompt-defaults

nvandessel commented Feb 28, 2026

Uh oh!

coderabbitai bot commented Feb 28, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

greptile-apps bot commented Feb 28, 2026 •

edited

Loading

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 28, 2026

Uh oh!

greptile-apps bot Feb 28, 2026

Uh oh!

nvandessel commented Feb 28, 2026 •

edited

Loading

Uh oh!

nvandessel commented Feb 28, 2026

Uh oh!

codecov bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nvandessel commented Feb 28, 2026

Summary

Test plan

Uh oh!

coderabbitai bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

greptile-apps bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

nvandessel commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌴 Frond Stack

Uh oh!

nvandessel commented Feb 28, 2026

Uh oh!

codecov bot commented Feb 28, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Feb 28, 2026 •

edited

Loading

greptile-apps bot commented Feb 28, 2026 •

edited

Loading

nvandessel commented Feb 28, 2026 •

edited

Loading