Skip to content

Conversation

@Jacobfaib
Copy link
Contributor

This fixes the problem of not exposing --with-cudac to cupynumeric by default.

@Jacobfaib Jacobfaib requested review from bryevdv and tisaac July 31, 2025 14:43
@Jacobfaib Jacobfaib self-assigned this Jul 31, 2025
@Jacobfaib Jacobfaib added the bug Something isn't working label Jul 31, 2025
Copy link
Contributor

@tisaac tisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it makes sense to have the option to turn this off, either cm = ConfigurationManager(argv, MyPackage, include_default_deps=False) or cm.setup(include_default_deps=False)?

@Jacobfaib
Copy link
Contributor Author

Jacobfaib commented Jul 31, 2025

Would it makes sense to have the option to turn this off

Hmmm possibly. But it would add a bit of complexity (not literally -- its just a bool -- but by giving the caller a choice). To give some background here: aedifix was originally the build system for just Legate (and actually lived in the Legate repo under config, much like its inspiration, BuildSystem).

When we decided to extend it to cupynumeric, we moved it to this repo and made it project agnostic (though it already mostly was, as I figured this move would eventually happen). But it was only as agnostic as Legate or cupynumeric needed it to be.

All this is to say: let's add this when we need it. aedifix is purely an in-house tool. It exists to serve exactly Legate and cupynumeric, and not a single project more (though maybe legate-sparse). Any features that it has, are because either Legate or cupynumeric needed them.

But I am open to having my mind changed, just don't want to complicate things apriori. WDYT @tisaac @bryevdv?

@tisaac
Copy link
Contributor

tisaac commented Jul 31, 2025

All this is to say: let's add this when we need it.

I agree.

@Jacobfaib Jacobfaib merged commit 104a8bd into main Jul 31, 2025
4 checks passed
@Jacobfaib Jacobfaib deleted the jacobf/2025-07-31/add-default-packages-by-default branch July 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants