fix(gtm): invoke onBeforeGtmStart callback when ID is in config#584
Merged
fix(gtm): invoke onBeforeGtmStart callback when ID is in config#584
Conversation
Combined commits: - fix(plausible): use consistent window reference in clientInit stub
When GTM ID is configured in nuxt.config, the plugin pre-initializes the script before user components mount. This caused onBeforeGtmStart callbacks passed to useScriptGoogleTagManager() to never be invoked. Now checks if script was already initialized (gtag exists) and invokes the callback immediately for cached/pre-initialized scripts. Closes #522 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #522
❓ Type of change
📚 Description
When GTM ID is configured in
nuxt.config.scripts.registry, the module generates a plugin that pre-initializes the script at app startup—before any user components mount. This meantonBeforeGtmStartcallbacks passed later in components were never invoked sinceclientInithad already run with no callback in its closure.Now after
useRegistryScriptreturns, we check ifwindow.gtagalready exists (indicating pre-initialization) and immediately invoke the callback.