fix: move @nuxt/kit into peerDependencies#521
Closed
huang-julien wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Collaborator
|
Thanks for the PR. The issue is that if we opt in to new @nuxt/kit features, the end user may not have them, so I'm not sure if merging this is the best option. It would be better to fix the original issue upstream. Also, we should align to the https://github.com/nuxt/module-builder conventions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #519
❓ Type of change
This PR moves @nuxt/kit to peerDependencies so users in Nuxt 3 wouldn't have @nuxt/kit 4 getting used due to the dependency graph of nuxt scripts
📚 Description