Skip to content

NXPY-269: Fix functional test#329

Closed
S-Ghosh-Dev2 wants to merge 2 commits intowip-NXPY-270-upgrade-python-versionfrom
wip-NXPY-269-fix-functional-test
Closed

NXPY-269: Fix functional test#329
S-Ghosh-Dev2 wants to merge 2 commits intowip-NXPY-270-upgrade-python-versionfrom
wip-NXPY-269-fix-functional-test

Conversation

@S-Ghosh-Dev2
Copy link
Copy Markdown
Collaborator

@S-Ghosh-Dev2 S-Ghosh-Dev2 commented Mar 27, 2026

Summary by Sourcery

Update functional test GitHub Actions workflow configuration for current tooling and syntax.

CI:

  • Adjust functional test workflow trigger branch list syntax for pull_request events.
  • Update functional test workflow to run against Python 3.13.1 instead of 3.9.
  • Simplify Codecov upload step condition to use a single GitHub Actions expression.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the functional tests GitHub Actions workflow to use correct YAML syntax, a newer Python version, and a simplified conditional for Codecov upload, with a no-op changelog touch.

File-Level Changes

Change Details Files
Fix GitHub Actions workflow syntax for pull_request branches specification.
  • Change pull_request branches from scalar "" to array syntax [""], matching expected schema for GitHub Actions.
.github/workflows/functional_tests.yml
Update Python version used in functional test matrix to the latest supported version.
  • Replace Python 3.9 entry in the test matrix with Python 3.13.1 and remove outdated comment about 3.10 alpha status.
.github/workflows/functional_tests.yml
Simplify and correct the condition for always uploading coverage to Codecov.
  • Change the if expression from `${{ success() }}
Touch the changelog file without adding entries yet.
  • Keep CHANGELOG.rst present/updated for potential future release notes without functional modifications.
CHANGELOG.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • For the Codecov step, if: ${{ success() || failure() }} is effectively always true and can be simplified to if: always() (without the expression wrapper) for better readability and to match common GitHub Actions patterns.
  • Bumping the Python version in the matrix directly to 3.13.1 in functional tests may diverge from what most users run in production; consider aligning this with the officially supported Python versions (or using a small matrix) so the workflow better reflects real-world environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the Codecov step, `if: ${{ success() || failure() }}` is effectively always true and can be simplified to `if: always()` (without the expression wrapper) for better readability and to match common GitHub Actions patterns.
- Bumping the Python version in the matrix directly to 3.13.1 in functional tests may diverge from what most users run in production; consider aligning this with the officially supported Python versions (or using a small matrix) so the workflow better reflects real-world environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the functional test GitHub Actions workflow and changelog entry for NXPY-269 (“Fix functional test”).

Changes:

  • Adjusts the functional test workflow’s PR branch filter and Codecov upload if: expression.
  • Updates the functional test workflow’s Python version in the matrix.
  • Adds NXPY-269 to the 6.1.3 changelog section (and updates the placeholder release year).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

File Description
CHANGELOG.rst Adds NXPY-269 entry under 6.1.3 and updates the placeholder release date year.
.github/workflows/functional_tests.yml Tweaks PR trigger branch syntax, changes Python matrix version, and fixes Codecov upload condition expression.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@S-Ghosh-Dev2 S-Ghosh-Dev2 deleted the wip-NXPY-269-fix-functional-test branch March 27, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants