NXPY-269: Fix functional test#329
Closed
S-Ghosh-Dev2 wants to merge 2 commits intowip-NXPY-270-upgrade-python-versionfrom
Closed
NXPY-269: Fix functional test#329S-Ghosh-Dev2 wants to merge 2 commits intowip-NXPY-270-upgrade-python-versionfrom
S-Ghosh-Dev2 wants to merge 2 commits intowip-NXPY-270-upgrade-python-versionfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the functional tests GitHub Actions workflow to use correct YAML syntax, a newer Python version, and a simplified conditional for Codecov upload, with a no-op changelog touch. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
…fix-functional-test
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the Codecov step,
if: ${{ success() || failure() }}is effectively always true and can be simplified toif: always()(without the expression wrapper) for better readability and to match common GitHub Actions patterns. - Bumping the Python version in the matrix directly to 3.13.1 in functional tests may diverge from what most users run in production; consider aligning this with the officially supported Python versions (or using a small matrix) so the workflow better reflects real-world environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the Codecov step, `if: ${{ success() || failure() }}` is effectively always true and can be simplified to `if: always()` (without the expression wrapper) for better readability and to match common GitHub Actions patterns.
- Bumping the Python version in the matrix directly to 3.13.1 in functional tests may diverge from what most users run in production; consider aligning this with the officially supported Python versions (or using a small matrix) so the workflow better reflects real-world environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Updates the functional test GitHub Actions workflow and changelog entry for NXPY-269 (“Fix functional test”).
Changes:
- Adjusts the functional test workflow’s PR branch filter and Codecov upload
if:expression. - Updates the functional test workflow’s Python version in the matrix.
- Adds NXPY-269 to the 6.1.3 changelog section (and updates the placeholder release year).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.rst | Adds NXPY-269 entry under 6.1.3 and updates the placeholder release date year. |
| .github/workflows/functional_tests.yml | Tweaks PR trigger branch syntax, changes Python matrix version, and fixes Codecov upload condition expression. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update functional test GitHub Actions workflow configuration for current tooling and syntax.
CI: