Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use Python 3.13.1 instead of 3.9 across tests, lint, types, and release pipelines, and simplifies the Codecov conditional expression syntax. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline comments in the workflows still reference 3.9 and 3.10 being in alpha; these should be updated or removed to avoid confusion now that the max version is 3.13.1.
- Consider using a major.minor version specifier (e.g.,
3.13instead of3.13.1) inactions/setup-pythonand the matrices to reduce churn when patch versions are updated.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline comments in the workflows still reference 3.9 and 3.10 being in alpha; these should be updated or removed to avoid confusion now that the max version is 3.13.1.
- Consider using a major.minor version specifier (e.g., `3.13` instead of `3.13.1`) in `actions/setup-python` and the matrices to reduce churn when patch versions are updated.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Updates the repository’s CI/release configuration to run against a newer Python version as part of NXPY-270.
Changes:
- Bump GitHub Actions workflow Python versions from 3.9 to 3.13.1 (tests, lint, types, release).
- Fix Codecov upload step
if:expression syntax in unit/functional test workflows. - Add NXPY-270 entry and update the 6.1.3 release-date placeholder in the changelog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.rst | Adds NXPY-270 and updates the 6.1.3 release-date placeholder year. |
| .github/workflows/unit_tests.yml | Runs unit tests on Python 3.13.1; adjusts Codecov upload condition. |
| .github/workflows/functional_tests.yml | Runs functional tests on Python 3.13.1; adjusts Codecov upload condition. |
| .github/workflows/lint.yml | Runs lint job on Python 3.13.1. |
| .github/workflows/types.yml | Runs type-check job on Python 3.13.1. |
| .github/workflows/release.yml | Builds wheel/sdist on Python 3.13.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ncies, Updated workflow to install tox only, Updated metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Upgrade the project’s CI workflows to use Python 3.13.1 instead of 3.9 across testing and release pipelines.
CI:
Documentation: