Skip to content

NXPY-270: Upgrade Python version#328

Open
S-Ghosh-Dev2 wants to merge 7 commits intomasterfrom
wip-NXPY-270-upgrade-python-version
Open

NXPY-270: Upgrade Python version#328
S-Ghosh-Dev2 wants to merge 7 commits intomasterfrom
wip-NXPY-270-upgrade-python-version

Conversation

@S-Ghosh-Dev2
Copy link
Copy Markdown
Collaborator

@S-Ghosh-Dev2 S-Ghosh-Dev2 commented Mar 26, 2026

Summary by Sourcery

Upgrade the project’s CI workflows to use Python 3.13.1 instead of 3.9 across testing and release pipelines.

CI:

  • Update functional, unit, lint, and type-check GitHub Actions workflows to run on Python 3.13.1.
  • Adjust Codecov upload condition syntax in test workflows to the recommended GitHub Actions expression form.

Documentation:

  • Prepare changelog for documenting the Python version upgrade.

Copilot AI review requested due to automatic review settings March 26, 2026 04:34
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use Python 3.13.1 instead of 3.9 across tests, lint, types, and release pipelines, and simplifies the Codecov conditional expression syntax.

File-Level Changes

Change Details Files
Upgrade CI test matrices to run against Python 3.13.1.
  • Update the Python version in the functional tests workflow matrix from 3.9 to 3.13.1.
  • Update the Python version in the unit tests workflow matrix from 3.9 to 3.13.1.
.github/workflows/functional_tests.yml
.github/workflows/unit_tests.yml
Upgrade Python version used for linting and type-checking workflows to 3.13.1.
  • Change the configured Python version from 3.9 to 3.13.1 in the lint workflow.
  • Change the configured Python version from 3.9 to 3.13.1 in the types workflow.
.github/workflows/lint.yml
.github/workflows/types.yml
Upgrade Python version used in release workflows to 3.13.1.
  • Update the wheel build job to use Python 3.13.1 instead of 3.9.
  • Update the sdist build job to use Python 3.13.1 instead of 3.9.
.github/workflows/release.yml
Normalize Codecov upload condition syntax in test workflows.
  • Replace the verbose `${{ success() }}

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The inline comments in the workflows still reference 3.9 and 3.10 being in alpha; these should be updated or removed to avoid confusion now that the max version is 3.13.1.
  • Consider using a major.minor version specifier (e.g., 3.13 instead of 3.13.1) in actions/setup-python and the matrices to reduce churn when patch versions are updated.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The inline comments in the workflows still reference 3.9 and 3.10 being in alpha; these should be updated or removed to avoid confusion now that the max version is 3.13.1.
- Consider using a major.minor version specifier (e.g., `3.13` instead of `3.13.1`) in `actions/setup-python` and the matrices to reduce churn when patch versions are updated.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s CI/release configuration to run against a newer Python version as part of NXPY-270.

Changes:

  • Bump GitHub Actions workflow Python versions from 3.9 to 3.13.1 (tests, lint, types, release).
  • Fix Codecov upload step if: expression syntax in unit/functional test workflows.
  • Add NXPY-270 entry and update the 6.1.3 release-date placeholder in the changelog.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
CHANGELOG.rst Adds NXPY-270 and updates the 6.1.3 release-date placeholder year.
.github/workflows/unit_tests.yml Runs unit tests on Python 3.13.1; adjusts Codecov upload condition.
.github/workflows/functional_tests.yml Runs functional tests on Python 3.13.1; adjusts Codecov upload condition.
.github/workflows/lint.yml Runs lint job on Python 3.13.1.
.github/workflows/types.yml Runs type-check job on Python 3.13.1.
.github/workflows/release.yml Builds wheel/sdist on Python 3.13.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants