Issue#304: Fix unable to detect a pattern from default theme having same id as the pattern in the base theme.#305
Open
msnassar wants to merge 1 commit intonuvoleweb:8.x-1.xfrom
Open
Issue#304: Fix unable to detect a pattern from default theme having same id as the pattern in the base theme.#305msnassar wants to merge 1 commit intonuvoleweb:8.x-1.xfrom
msnassar wants to merge 1 commit intonuvoleweb:8.x-1.xfrom
Conversation
…ame id as the pattern in the base theme.
|
This works nicely but as discussed yesterday, we should provide test in the ui_patterns PR. |
|
There is another issue with the I think @vever001's proposal in #304 (comment) might be a better strategy here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #304