Process the definition via layout plugin manager, so the new plugin get fully populated.#289
Open
dlopez-akalam wants to merge 1 commit intonuvoleweb:8.x-1.xfrom
dlopez-akalam:fb-populate-plugin-definition
Open
Process the definition via layout plugin manager, so the new plugin get fully populated.#289dlopez-akalam wants to merge 1 commit intonuvoleweb:8.x-1.xfrom dlopez-akalam:fb-populate-plugin-definition
dlopez-akalam wants to merge 1 commit intonuvoleweb:8.x-1.xfrom
dlopez-akalam:fb-populate-plugin-definition
Conversation
…et fully populated.
Contributor
|
I applied the patch and my pattern crashes in layout_discovery.module:44. There is no content variable. Did I missed something. |
The same happens for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As long as the plugin manager process the definition individually there would be no performance impact.
Without the patch \Drupal\Core\Layout\LayoutPluginManager::getThemeImplementations() process wrongly the layout patterns