fix: allow to set K8s namespace via env var#452
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Kubernetes namespace handling logic by moving namespace extraction from manifest files from the Kubernetes class to the K8sDriver class, making it private. The change relocates the namespace validation logic to be closer to where the manifest is actually applied.
- Moved namespace extraction logic from
Kubernetes.start()toK8sDriver.apply_manifest_with_context() - Made the
get_all_namespaces_from_manifestmethod private by renaming it to_get_all_namespaces_from_manifest - Simplified the namespace handling in the
Kubernetes.start()method to use deployment UUID as default
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nuvla/job_engine/connector/kubernetes.py | Removed namespace extraction logic and simplified to use deployment UUID as default namespace |
| nuvla/job_engine/connector/k8s_driver.py | Added namespace extraction and validation logic, made the helper method private |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/SixSq/tasklist/issues/3543