[AY1920S1-CS2113T-F14-3] Contact List Pro#95
Open
TehZiHuai wants to merge 559 commits intonusCS2113-AY1920S1:masterfrom
Open
[AY1920S1-CS2113T-F14-3] Contact List Pro#95TehZiHuai wants to merge 559 commits intonusCS2113-AY1920S1:masterfrom
TehZiHuai wants to merge 559 commits intonusCS2113-AY1920S1:masterfrom
Conversation
langyanbin0314
left a comment
langyanbin0314
left a comment
There was a problem hiding this comment.
pay attention to if .. else .. format
Comment on lines
+6
to
+19
| private static final String outOfBounds_Text = "Index is out of Bounds!"; | ||
| private static final String anomaly_Text = "Anomaly Detected"; | ||
| private static final String emptyList_Text = "List is empty"; | ||
| private static final String timeClash_Text = "Time Clash Detected"; | ||
| private static final String wrongFormat_Text = "Wrong Format Detected"; | ||
| private static final String wrongPriority_Text = "You've entered wrong format of priority"; | ||
| private static final String subTask_Text = "Meetings do not support Subtasks"; | ||
| public static final String wrongTaskType_Text = "Only meeting or assignment tag are accepted"; | ||
| public static final String emptyDescription_Text = "You haven't included the description of you task"; | ||
| public static final String emptyDate_Text = "You haven't included the date of your task"; | ||
| public static final String emptyTaskType_Text = "You haven't specified the type of your task: assignment or meeting"; | ||
| public static final String writeError_Text = "Error in writing file, cancelling write process..."; | ||
| public static final String wrongIndexFormat_Text = "The index you've enter is in the wrong format"; | ||
| public static final String wrongTimeFormat_Text = "You've entered an invalid time format"; |
| * @param type type of exception detected | ||
| */ | ||
| public RoomShareException(ExceptionType type){ | ||
| switch(type) { |
| /** | ||
| * This class checks if there are clashes in timings for events | ||
| */ | ||
| public class CheckAnomaly { |
src/main/java/Operations/Parser.java
Outdated
| * @param by Input String containing the date information. | ||
| * @return A Date object containing the appropriately formatted date. | ||
| */ | ||
| public Date formatDateCustom_1(String by) { |
There was a problem hiding this comment.
more descriptive function name.
| int minutes = Integer.parseInt(time[1]); | ||
| date.setHours(hours); | ||
| date.setMinutes(minutes); | ||
| if (day.toLowerCase().equals("tomorrow") || day.toLowerCase().equals("tmr")) { |
|
|
||
| import CustomExceptions.RoomShareException; | ||
| import Enums.RecurrenceScheduleType; | ||
| import Model_Classes.*; |
There was a problem hiding this comment.
do not import*, only import used classes
| * @param isEdited boolean variable describing if the task list has been edited in anyway | ||
| * @return | ||
| */ | ||
| private boolean dateHasPassedOthers(String currentTime, Task check, boolean isEdited) { |
| String[] descriptionArray2 = descriptionArray[1].trim().split("\\)"); | ||
| description = descriptionArray2[0].trim(); | ||
| } | ||
| else |
| unit = TimeUnit.unDefined; | ||
| } | ||
| } | ||
| else { |
add function to update tasks
update my code
add function to create and write log files
add logs folder
add auto generate logs folder
update cide base
added tests
� Conflicts: � src/main/java/Model_Classes/Task.java
update my code
updated tests for taskcreator
Added CheckAnomalyTest & test.txt
getting test.txt data set
Merge pull request #230 from tyeryan/master
bugfixes on logic and ui
updated 10/11
Reordered help list to tally with quickstart guide in UG
style enforcement, bug fix on CheckAnomaly
improved accuracy of descriptions in help
updated 11/11
Updated for checkstyle violations
added UGDG
nishanthelango
pushed a commit
to nishanthelango/Duchess
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.