[AY1920S1-CS2113-T14-2] restaurant manager#92
[AY1920S1-CS2113-T14-2] restaurant manager#929hafidz6 wants to merge 518 commits intonusCS2113-AY1920S1:masterfrom
Conversation
sanjukta99
left a comment
sanjukta99
left a comment
There was a problem hiding this comment.
Overall, good progress. Take a look at my suggestions.
You should follow the Java Coding Standards for JavaDoc comments and naming conventions. We also recommend that you delete commented out code as it makes the code more readable.
| import java.util.List; | ||
|
|
||
| public class DishList { | ||
| private List<Dishes> dishlist; |
There was a problem hiding this comment.
Important that you write proper JavaDoc comments for all classes. You can find the Java Coding Standards on the module website
|
|
||
| // public String toString() { | ||
| // return dishname; | ||
| // } |
There was a problem hiding this comment.
It's best to delete commented out code
src/main/java/duke/command/Cmd.java
Outdated
| import duke.ui.Ui; | ||
|
|
||
| public abstract class Cmd<T> { | ||
| public abstract void execute(T tasklist, Ui ui, Storage storage) throws DukeException; |
There was a problem hiding this comment.
Maybe using a more descriptive name like Command might be better?
| private Dishes dish; | ||
| private int amount; | ||
| private int Nb; | ||
|
|
There was a problem hiding this comment.
What is Nb? Better to use a more descriptive name. That way even someone who's reading your code for the first time can understand what's going on in that part of the code
| * Convert between String and Date. | ||
| */ | ||
| public class Convert { | ||
|
|
There was a problem hiding this comment.
Convert what? Consider renaming to something more descriptive
src/test/FridgeTest.java
Outdated
| Fridge fridge = new Fridge(); | ||
| @Test | ||
| void testPutIngredient() throws DukeException { | ||
| fridge = new Fridge(); |
There was a problem hiding this comment.
Names for tests should follow the format featureUnderTest_testScenario_expectedBehavior(). Update accordingly for all the testcases
* updated UG implemented while loop in Duke class for Dish modified parser to handle more errors
updated DG and UG
update multi-level command
update Parser, Ui, and Duke main class.
update order feature
Updating my end
to fix issues reported by PED run
2. Format order command to make sense and better user experience. 3. Add functions to check for valid date/month/year. 4. Fix update problem in setting an order date. 5. Extract Parser.parse function case "c" to several subfunctions--look neat. 6. Fix crashes when converting a string to date. 7. Fix small typo when printing out messages.
More neat order command and handle exceptions
… clear list" provides no visual indication #87
* additional Javadoc * updated UG
* minor update to UG and DG
some changes to DG
added a check for ingredient name length,
DG update
will upload ppp later
Update dg
7 participants
No description provided.