[AY1920S1-CS2113-T09-1] Hustler#91
Open
yzia2000 wants to merge 808 commits intonusCS2113-AY1920S1:masterfrom
Open
[AY1920S1-CS2113-T09-1] Hustler#91yzia2000 wants to merge 808 commits intonusCS2113-AY1920S1:masterfrom
yzia2000 wants to merge 808 commits intonusCS2113-AY1920S1:masterfrom
Conversation
seanieyap
reviewed
Oct 18, 2019
seanieyap
left a comment
seanieyap
left a comment
There was a problem hiding this comment.
Overall good job. Just some coding quality issues like magic numbers and commenting issues.
Comment on lines
+49
to
+50
| taskType = "deadline"; | ||
| break; |
Comment on lines
+52
to
+53
| taskType = "event"; | ||
| break; |
Comment on lines
+55
to
+56
| ui.show_message("/" + timeCommand + " is an invalid addition to /add"); | ||
| return; |
|
|
||
| Hustler.saveStorage(); | ||
| } catch (CommandLineException | IOException e) { | ||
|
|
Comment on lines
+10
to
+52
| public class CommandLog { | ||
|
|
||
| private static ArrayList<String> commandlog; | ||
| private static boolean isRestoring = false; | ||
|
|
||
| public CommandLog() { | ||
| commandlog = new ArrayList<String>(); | ||
| } | ||
|
|
||
| public static void recordCommand(String command) { | ||
| commandlog.add(command); | ||
| } | ||
|
|
||
| public static void restoreData(int numberOfCommandsToUndo) { | ||
| isRestoring = true; | ||
| int restoreDataUntil = commandlog.size() - numberOfCommandsToUndo; | ||
|
|
||
| if (restoreDataUntil >= 0) { | ||
| for (int i = 0; i < restoreDataUntil; i++) { | ||
| try { | ||
| CommandParser parser = new CommandParser(); | ||
|
|
||
| Command command = parser.parse(commandlog.get(i)); | ||
| command.execute(); | ||
|
|
||
| Hustler.saveStorage(); | ||
| } catch (CommandLineException | IOException e) { | ||
|
|
||
| } | ||
| } | ||
|
|
||
| while (commandlog.size() > restoreDataUntil) { | ||
| commandlog.remove(restoreDataUntil); | ||
| } | ||
| } else { | ||
| System.out.println("Error! You are attempting to undo more commands than is possible!"); | ||
| } | ||
| isRestoring = false; | ||
| } | ||
|
|
||
| public static boolean isRestoring() { | ||
| return isRestoring; | ||
| } |
There was a problem hiding this comment.
Missing header comments. All non trivial methods should have javadoc format header comments. You have done so for the rest of the classes but not here.
Comment on lines
+106
to
+107
| suffix = "st"; | ||
| break; |
Comment on lines
+15
to
+34
| /** | ||
| * Reminder list that contains tasks that are overdue. | ||
| */ | ||
| private static ArrayList<Task> overDueList = new ArrayList<>(); | ||
| /** | ||
| * Reminder list that contain tasks with less than 30 minutes or less till deadline. | ||
| */ | ||
| private static ArrayList<Task> lastDayList = new ArrayList<>(); | ||
| /** | ||
| * Reminder list htat contain tasks with less than 24 hours or less till deadline. | ||
| */ | ||
| private static ArrayList<Task> lastThirtyMinutesList = new ArrayList<>(); | ||
| /** | ||
| * 24 hours converted to seconds. | ||
| */ | ||
| private static final int TWENTY_FOUR_HOURS = 86400; | ||
| /** | ||
| * 30 minutes converted to seconds. | ||
| */ | ||
| private static final int THIRTY_MINUTES = 1800; |
There was a problem hiding this comment.
New lines should seperate these since they have comments
Comment on lines
+94
to
+98
| if (!done && checkDeadline || checkEvent || checkRange) { | ||
| if (checkOverdue(i)) { | ||
| overDueList.add(list.get(i)); | ||
| } | ||
| } |
There was a problem hiding this comment.
These two if statements can be combined into one.
| public static void displayReminders() { | ||
| if (!overDueList.isEmpty()) { | ||
| if (overDueList.size() == 1) { | ||
| System.out.println("\t_____________________________________"); |
There was a problem hiding this comment.
These lines can be saved into some variable since they are used so many times. Also to avoid "magic strings"; if you need to change these in the future, it would be a hassle to do so to all of them.
Comment on lines
+118
to
+119
| this.tag.toString() + " " + | ||
| this.getDescription(); |
|
Please code this PR after reading my comments. |
Fixed null pointer exception
# Conflicts: # src/main/java/seedu/hustler/game/avatar/Inventory.java # src/main/java/seedu/hustler/logic/command/avatar/CheckAvatarCommand.java # src/main/java/seedu/hustler/logic/parser/anomaly/AddCommandAnomaly.java
Rename statusTypes.java to StatusTypes.java
… into branch-Achievements
Fixed small checkstyle error
TaskStorageTest fix
… into branch-Achievements
undo fixes
Fixed checkstyle errors for JUNIT testing
[AY1920S1-CS2113T-T09-1]-jingkang97-Fixed checkstyle for reminders
Fixed reminders checkstyle
fixed comments
final checkstyle fix
fixed checkstyle
Fixed Recommended Schedule bug for test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ngjiewu
@nystera
@jingkang97
@EnriqueKhai
@yzia2000