[AY1920S1-CS2113T-W13-2] JavaCake by RusdiHaizim · Pull Request #88 · nusCS2113-AY1920S1/PersonalAssistant-Duke

RusdiHaizim · 2019-10-16T04:27:13Z

@claysmilesoil @GlenWong97 @kishore03109

flxffy

Overall, pretty good job and your code is quite readable.

Things to note:

Variable names can be more descriptive.
Remnants of Duke, especially the exceptions.
A lot of magic numbers.
Some methods are really long.
Code that has been commented out can be removed.
Make use of super class constructors and use proper @Override annotations. Question and its sub-classes were really well done, you can take a look at that!
Not a lot of tests, but what you have now is a good start!

flxffy · 2019-10-21T16:45:14Z

src/main/java/javacake/Parser.java

+        if (input.equals("exit")) {
+            return new ExitCommand();
+        } else if (input.equals("list")) {
+            return new ListCommand();
+        } else if (input.equals("back")) {
+            return new BackCommand();
+        } else if (input.equals("help")) {
+            return new HelpCommand(inputCommand);
+        } else if (input.equals("score")) {
+            return new ScoreCommand();
+        } else if (input.equals("reset")) {
+            return new ResetCommand();
+        } else if (input.equals("goto")) {
+            if (inputCommand.length() <= 4) {
+                throw new DukeException("Please specify index number in 'goto' command!");
+            }
+            return new GoToCommand(inputCommand.substring(5));
+        } else if (input.equals("tree")) {
+            return new MegaListCommand();
+        } else if (input.equals("deadline")) {
+            return new AddCommand(inputCommand);
+        } else {
+            throw new DukeException("OOPS!!! I'm sorry, but I don't know what that means.");
+        }


There's a better way to do this! Good attempt though, it looks neat :)

flxffy · 2019-10-21T16:47:53Z

src/main/java/javacake/ProgressStack.java

+    /**
+     * Stores all files in the currentFilePath into listOfFiles.
+     */
+    public void loadFiles() throws DukeException {


This is a very long method. Look up ways to refactor code.

flxffy · 2019-10-21T16:48:25Z

src/main/java/javacake/ProgressStack.java

+    public ProgressStack() {
+
+    }


Empty constructor? Look up default constructors.

flxffy · 2019-10-21T16:50:04Z

src/main/java/javacake/ProgressStack.java

+        String finalTrim = reducedFilePath.toString();
+        finalTrim = finalTrim.substring(0, finalTrim.length() - 1);
+        return finalTrim;


finalTrim is a very vague variable name, it could be more descriptive.

flxffy · 2019-10-21T16:51:09Z

src/main/java/javacake/commands/AddCommand.java

+        /*switch (type) {
+        case TODO:
+            ui.showMessage(Parser.runTodo(progressStack.getData(), input, Parser.TaskState.NOT_DONE));
+            storage.write(progressStack.getData());
+            break;
+        case DEADLINE:
+            ui.showMessage(Parser.runDeadline(progressStack.getData(), input, Parser.TaskState.NOT_DONE));
+            storage.write(progressStack.getData());
+            break;
+        case EVENT:
+            ui.showMessage(Parser.runEvent(progressStack.getData(), input, Parser.TaskState.NOT_DONE));
+            storage.write(progressStack.getData());
+            break;
+        case DAILY:
+            ui.showMessage(Parser.runRecurring(progressStack.getData(), input, Parser.TaskState.NOT_DONE, "daily"));
+            storage.write(progressStack.getData());
+            break;
+        case WEEKLY:
+            ui.showMessage(Parser.runRecurring(progressStack.getData(), input, Parser.TaskState.NOT_DONE, "weekly"));
+            storage.write(progressStack.getData());
+            break;
+        case MONTHLY:
+            ui.showMessage(Parser.runRecurring(progressStack.getData(), input, Parser.TaskState.NOT_DONE, "monthly"));
+            storage.write(progressStack.getData());
+            break;
+        default:
+            throw new DukeException("     [Unknown COMMAND TYPE]");
+        }*/


Don't leave commented out code. Just go ahead and delete unused code. Now that we are using a revision control system, we can recover any deleted code later.

flxffy · 2019-10-21T17:02:56Z

src/main/java/javacake/storage/Profile.java

+    /**
+     * Constructor for profile.
+     * @param filename String of filepath
+     * @throws DukeException when unable to create profile
+     */
+    public Profile(String filename) throws DukeException {
+        try {
+            File file = new File("data/save/savefile.txt");
+            Duke.logger.log(Level.INFO,"Filepath: " + filepath);
+            try {
+                if (!file.getParentFile().getParentFile().exists()) {
+                    file.getParentFile().getParentFile().mkdir();
+                    file.getParentFile().mkdir();
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("A" + file.getParentFile().getParentFile().getPath());
+                } else if (!file.getParentFile().exists()) {
+                    file.getParentFile().mkdir();
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("B" + file.getParentFile().getPath());
+                } else if (!file.exists()) {
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("C" + file.getPath());
+                } else {
+                    Duke.logger.log(Level.INFO, filepath + " is found!");
+                }
+
+            } catch (IOException e) {
+                System.out.println("before reader");
+                throw new DukeException("Failed to create new file");
+            }
+
+            BufferedReader reader = new BufferedReader(new FileReader(filepath));
+            String line;
+            int count = -1;
+            while ((line = reader.readLine()) != null) {
+                if (count == -1) {
+                    username = line;
+                } else {
+                    topicsDone.add(Integer.parseInt(line));
+                }
+                ++count;
+            }
+            reader.close();
+        } catch (IOException e) {
+            System.out.println("after reader");
+            throw new DukeException("Failed to close reader");
+        }
+    }


The constructor is very lengthy.

flxffy · 2019-10-21T17:04:44Z

src/main/java/javacake/storage/Profile.java

+                if (!file.getParentFile().getParentFile().exists()) {
+                    file.getParentFile().getParentFile().mkdir();
+                    file.getParentFile().mkdir();
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("A" + file.getParentFile().getParentFile().getPath());
+                } else if (!file.getParentFile().exists()) {
+                    file.getParentFile().mkdir();
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("B" + file.getParentFile().getPath());
+                } else if (!file.exists()) {
+                    file.createNewFile();
+                    initialiseUser();
+                    System.out.println("C" + file.getPath());
+                } else {
+                    Duke.logger.log(Level.INFO, filepath + " is found!");
+                }


Good effort in keeping this neat and nicely formatted. However, having some comments here would be nice to help the developer understand your code.

flxffy · 2019-10-21T17:06:22Z

src/main/java/javacake/storage/Storage.java

+            if (!tasksFile.getParentFile().getParentFile().exists()) {
+                tasksFile.getParentFile().getParentFile().mkdir();
+                tasksFile.getParentFile().mkdir();
+                tasksFile.createNewFile();
+                System.out.println("A" + tasksFile.getParentFile().getParentFile().getPath());
+            } else if (!tasksFile.getParentFile().exists()) {
+                tasksFile.getParentFile().mkdir();
+                tasksFile.createNewFile();
+                System.out.println("B" + tasksFile.getParentFile().getPath());
+            } else if (!tasksFile.exists()) {
+                tasksFile.createNewFile();
+                System.out.println("C" + tasksFile.getPath());


This would be a good place to use a logger, as opposed to system io, since your team is already using one.

flxffy · 2019-10-21T17:07:27Z

src/main/java/javacake/tasks/Deadline.java

+     */
+    public Deadline(String description, String by) throws DukeException {
+        super(description);
+        this.by = by;


by is a very vague variable name.

flxffy · 2019-10-21T17:08:34Z

src/main/java/javacake/tasks/RecurringTask.java

+        try {
+            setFrequency(frequency);
+        } catch (DukeException e) {
+            //e.getMessage();
+        }


We went through this in class. https://nuscs2113-ay1920s1.github.io/website/schedule/week6/tutorial-cs2113.html

v1.3

+Resized window +Added some storage tests

error handling for files that are not named properly

v1.3: Implemented DeleteNoteCommand and refactored mainwindow

added 3 difficulity levels for quiz

v1.4 last min

nus-se-pr-bot added team.2 tutor.flxffy tutorial.CS2113T-W13 labels Oct 17, 2019

flxffy reviewed Oct 21, 2019

View reviewed changes

GlenWong97 and others added 26 commits October 27, 2019 13:11

Fixed typos

6cb94a3

Merge pull request #111 from RusdiHaizim/master

d5ae18d

v1.3

Changed Ui image for README

15e7f9d

Resolved merge conflict

7afc038

+Resized window +Added some storage tests

b90de7e

Merge pull request #112 from RusdiHaizim/master

5b7a92e

+Resized window +Added some storage tests

Refactored mainwindow

6841ac6

error handling for files that are not named properly

1c15a88

Merge pull request #113 from kishore03109/master

7278484

error handling for files that are not named properly

Implemented deletecommand for notes with documentation

a7fcbfe

Implemented deletenotecommand for JAR

91abd6d

Resolved merge conflicts

99c34a3

Fixed checkstyle

3949773

Merge pull request #114 from GlenWong97/master

639129b

v1.3: Implemented DeleteNoteCommand and refactored mainwindow

added 3 difficulity levels for quiz

b7eeb8e

test errors fixed

48da7b0

test errors fixed

b9a0cec

fixed bugs for new user

b62c2d6

Merge pull request #115 from kishore03109/master

12d7004

added 3 difficulity levels for quiz

minor changes

d72a58a

Merge remote-tracking branch 'upstream/master'

cb68c72

Refreshed notes after reset

d1ca16c

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-W13-2/main

3737686

Added sad face when exiting app

8807a20

Refactored parser and gotocomocommand

be5a92f

Renamed Duke to JavaCake ane and DukeException to CakeException

3e000b7

RusdiHaizim and others added 30 commits November 11, 2019 19:37

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-W13-2/main

9e2f973

+Fixed exit bug when editting note; +Fixed IntellJ bug

ccd0c43

Merge pull request #180 from RusdiHaizim/master

f06eb06

v1.4 last min

Add files via upload

b5eed46

Update AboutUs.adoc

cdc84a8

Update AboutUs.adoc

77fb272

Update AboutUs.adoc

cc98e56

Added PPP

f09131c

Deleted PPP

5b1cf1c

Added PPP

a2519b1

Updated about us

7349f1f

Delete [CS2113T-W13-2][Rusdi Haizim B Rahim]PPP.pdf

531ab71

Add files via upload

536e6ec

Rename UserGuide.adoc to UserGuide_DEPRECATED.adoc

c76bcd7

Rename DeveloperGuide.adoc to DeveloperGuide_DEPRECATED.adoc

2b18a64

Delete [CS2113T-W13-2][JavaCake]DeveloperGuide.pdf

2360907

Delete [CS2113T-W13-2][JavaCake]UserGuide.pdf

4707f40

Add files via upload

27b8afc

PPP

73fa64d

added PPP

126775a

Update AboutUs.adoc

10ba148

Add files via upload

288f04c

Add files via upload

e39b85d

Add files via upload

b649b31

Delete [CS2113T-W13-2]-[Kishore R]PPP.pdf

b3e85cf

Added PPP

b5d247c

Delete [CS2113T-W13-2][Kishore R]PPP.docx.pdf

529c978

Delete [CS2113T-W13-2][Kishore R]PPP.pdf

9493428

Adding PPP

75fb32f

Update AboutUs.adoc

e21065a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AY1920S1-CS2113T-W13-2] JavaCake#88

[AY1920S1-CS2113T-W13-2] JavaCake#88
RusdiHaizim wants to merge 596 commits intonusCS2113-AY1920S1:masterfrom
AY1920S1-CS2113T-W13-2:master

RusdiHaizim commented Oct 16, 2019

Uh oh!

flxffy left a comment •

edited

Loading

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

flxffy Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

RusdiHaizim commented Oct 16, 2019

Uh oh!

flxffy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flxffy left a comment •

edited

Loading