[AY1920S1-CS2113-F10-3] AlphaNUS#78
Open
leowyh wants to merge 476 commits intonusCS2113-AY1920S1:masterfrom
Open
[AY1920S1-CS2113-F10-3] AlphaNUS#78leowyh wants to merge 476 commits intonusCS2113-AY1920S1:masterfrom
leowyh wants to merge 476 commits intonusCS2113-AY1920S1:masterfrom
Conversation
langyanbin0314
left a comment
langyanbin0314
left a comment
There was a problem hiding this comment.
Should add more unit tests.
Consider using switch case and enum for keyword matching
src/main/java/AlphaNUS.java
Outdated
| private static Ui ui; | ||
| private static TaskList tasklist; | ||
| private static Storage storage; | ||
| private static HashMap<String, Payee> managermap; |
There was a problem hiding this comment.
use camel case for variable name
src/main/java/Main.java
Outdated
Comment on lines
+5
to
+6
| //import javafx.application.Application; | ||
| //import javafx.scene.Scene; |
| package command; | ||
|
|
||
| public class Instruction { | ||
|
|
There was a problem hiding this comment.
for the whole class, extract the strings into variables
src/main/java/command/Parser.java
Outdated
| * @return Returns boolean variable to indicate when to stop parsing for input. | ||
| * @throws AlphaNUSException if input is not valid. | ||
| */ | ||
| public static boolean parse(String input, TaskList tasklist, Ui ui, |
Added HIstory feature to DG
Add Payee Feature to DG
history feature DG
added sequence diagram for history
Updated DG
…edHashMap for easier iteration
update 28.oct
…ap, Integrated Projectmap into Payments functions
implemented assign fund feature
# Conflicts: # data/duke.txt # src/main/java/command/Parser.java
Removed debugging line
Removed debugging line
Fixed UG merge conflicts
updated UG
Update for Dev Guide
updated tasks
Updated PPP, Unit Tests, Command formats
Updated Unit Tests
updated dg
update ugdg and ppp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lijiayu980606
@karansarat
@E0373902