[AY1920S1-CS2113-T16-2] El Duque#35
[AY1920S1-CS2113-T16-2] El Duque#35nicholasnovakovic wants to merge 370 commits intonusCS2113-AY1920S1:masterfrom
Conversation
nicholasnovakovic
changed the title
Rework UI for date time input
fix bug with filtered edit command
sanjukta99
left a comment
sanjukta99
left a comment
There was a problem hiding this comment.
Take a look at my comments for some suggestions about your code. Keep in mind the Java Coding standards.
I have noticed that most of the commands so far are the Duke commands. I hope you are working on your new features already. Feel free to speak to us if you are facing any difficulty!
|
|
||
|
|
||
| public AddCommand(String description, String taskType, Optional<String> filter) { | ||
| this.taskType = taskType; |
There was a problem hiding this comment.
Important that you guys have JavaDoc comments for all classes. You can find the Java Coding Standards on the moduel website
| } | ||
| if (filter == tempTaskList.get(i).getFilter()) { | ||
| filteredListCounter++; | ||
| } |
There was a problem hiding this comment.
Is the indentation for this if statement correct?
| String keyword = fcArray[0]; | ||
|
|
||
| switch (keyword) { | ||
| case "bye": |
There was a problem hiding this comment.
There is no indentation for case clauses in Java. Configure CheckStyle to follow this style
| * .create(); | ||
| * }</pre> | ||
| * Like {@code GsonBuilder}, this API supports chaining: <pre> {@code | ||
| * RuntimeTypeAdapterFactory<Shape> shapeAdapterFactory = RuntimeTypeAdapterFactory.of(Shape.class) |
There was a problem hiding this comment.
Best to delete commented out code. Makes your code more readable
src/main/java/duke/task/Task.java
Outdated
| } | ||
|
|
||
| public void setPriority(int i) throws DukeException { | ||
| switch(i) { |
There was a problem hiding this comment.
Could the getting and setting of priority be handled elsewhere? (take note of SoC)
src/test/java/AddCommandTest.java
Outdated
| // assertEquals(LocalDate.of(2019, 10, 19), a.convertToLocalDate("19102019 1000")); | ||
| // final AddCommand b = new AddCommand("homework", "19012019 1000"); | ||
| // assertEquals(LocalDate.of(2019, 01, 19), a.convertToLocalDate("19012019 1000")); | ||
| } |
src/test/java/EditCommandTest.java
Outdated
| public class EditCommandTest { | ||
|
|
||
| // @Test | ||
|
|
There was a problem hiding this comment.
I would suggest that you guys write some test code, as and when you update the code
Added new print functionality
Optimised Parser, Command, Storage. Deleted Deadline and ToDo classes
Optimised TaskList
Optimised AddCommand
Optimised Event
Optimised Task
Created DateTimeParser
Optimise UI interface
fix check style issues
Update DG and UndoCommandTest
fixed checkstyle
Update Documentation
5 participants
@shaun97
@nimiew