[AY1920S1-CS2113-T13-3] Chronologer by hanskw4267 · Pull Request #34 · nusCS2113-AY1920S1/PersonalAssistant-Duke

hanskw4267 · 2019-09-11T13:56:06Z

@TanYiXiang
@E0310898
@fauzt
@assman
@hanskw4267

added to readme.md

RubaP

As a team, please go through the comments even if it is related to one person's code. I havent repeated pointing out the same mistake. In design, I have the same confusion that I raised in UG and DG feedback. It is not very clear why there are so many classes with minor attribute variations (or without any difference). In case, If these class will have behavioural changes in future then it should be fine. Otherwise, it is pointless to create so many classes with minor/no difference.

RubaP · 2019-10-21T07:46:40Z

src/main/java/DialogBox.java

+    }
+
+    /**
+     * The getUserDialog distinction is needed to enable the flipping of the labels to create the chat bot like


The method comment should start with a simple present. Once you explain 'what it does' in the first sentence, then you can explain 'why' or any other important information to be conveyed

RubaP · 2019-10-21T07:48:58Z

src/main/java/Duke.java

-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+
+    private String filePath = System.getProperty("user.dir") + "/src/DukeDatabase/ArrayList";


The magical strings should be defined as a constant. Even if the filePath changes somewhere in the middle of the process, the magical postfix can be defined as a constant with the name indicating it is a default one

RubaP · 2019-10-21T07:50:43Z

src/main/java/Duke.java

    }
+
+    /**
+     * This method runs the main program.


This should be 'Runs the main program'. I will not point out the same mistake in the method comment in the following implementation. Please make sure it is fixed everywhere.

The class was rendered redundant, fixed this issue across the project

RubaP · 2019-10-21T07:53:54Z

src/main/java/Main.java

+            FXMLLoader fxmlLoader = new FXMLLoader(Main.class.getResource("/view/MainWindow.fxml"));
+            AnchorPane ap = fxmlLoader.load();
+            Scene scene = new Scene(ap);
+            stage.getIcons().add(new Image(getClass().getResourceAsStream("/images/GuiLogo.png")));


This method does not flow SLAP though it is very short. If start method does a functionality at the level of calling someone else's method (e.g. initializeDukeElements() ), then it should be maintained throughout the method. But here it does a very lower-level work of creating and setting object properties

RubaP · 2019-10-21T07:54:19Z

src/main/java/Main.java

+            Scene scene = new Scene(ap);
+            stage.getIcons().add(new Image(getClass().getResourceAsStream("/images/GuiLogo.png")));
+            stage.setScene(scene);
+            stage.setTitle("Chronologer");


Please define these magical strings as constants

RubaP · 2019-10-21T08:36:17Z

src/main/java/command/SearchCommand.java

+                    duration = ChronoUnit.HOURS.between(LocalDateTime.now(), dateList.get(i).startDate);
+                }
+                if (durationToFind <= duration) {
+                    if (i != 0) {


There are three levels of if here which is very hard to read and understand. Try to simplify it

RubaP · 2019-10-21T08:36:51Z

src/main/java/exception/DukeException.java

+    public static String wrongDateOrTime() {
+        Ui.printManual();
+        Ui.printDash();
+        return "☹ OOPS!!! The date or time of this add type command is not of the correct format."


Magical strings?

RubaP · 2019-10-21T08:39:41Z

src/main/java/parser/DateTimeExtractor.java

+    public static DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("dd/MM/yyyy HHmm");
+    private static LocalDateTime dateEvent;
+    private static LocalDateTime dateDeadline;
+    private static LocalDateTime datePostpone;


If you want to only assign and return, what is the purpose of having this many variables of same type. If you have any future use, then it should be fine.

RubaP · 2019-10-21T08:40:02Z

src/main/java/parser/Flag.java

+    BY("/by"),
+    AT("/at"),
+    BETWEEN("/between"), FOR("/for"),
+    IN("/in");


RubaP · 2019-10-21T08:41:32Z

src/main/java/parser/ParserFactory.java

+     * @throws DukeException The DukeException class has all the respective methods
+     *                       and messages!
+     */
+    public static Command parse(String userInput) throws DukeException {


Too lengthy to read and follow what it does. Try to simplify this by extracting out low-level operation to methods.

…e corruption.

…rt to. Command: export <file name>

…t date and end date.

…closer to a command line!

B refactor postpone

# Conflicts: # src/main/java/chronologer/command/ExportCommand.java

Implemented a history like feature for the chatbot.

…asks

B parser test

…l state.

Added test cases and did quite a few bug fixes.

minor quality edit

updated ui.png

added commands for testing purpose

DG & UG update after module lead approval.

* test * test * test * test * test * test * test * image * image * image * image * update * update * update * update * update

hanskw4267 changed the title ~~[AY1920S1-CS2113-T13-3] Duchess~~ [AY1920S1-CS2113-T13-3] Chronologer Sep 11, 2019

fauzt force-pushed the master branch from e8fd3a8 to 456995c Compare October 10, 2019 12:06

x3chillax referenced this pull request in x3chillax/main Oct 16, 2019

Merge pull request AY1920S1-CS2113-T14-2#34 from CEGLincoln/master

28b29a9

added to readme.md

nus-se-pr-bot added tutorial.CS2113-T13 tutor.RubaP team.3 labels Oct 17, 2019

RubaP reviewed Oct 21, 2019

View reviewed changes

TanYiXiang and others added 23 commits November 1, 2019 13:35

Added user guide pdf to doc

2db8377

Rename UserGuide.adoc to README.MD

d34e7b0

Update README.adoc

7a51a07

Updated the build.gradle to work on other Operating Systems.

bdc47bf

Fixed bye command, now it terminates.

153e867

Fix export command to not include dateless todo tasks as it will caus…

d9e4e3d

…e corruption.

Fix Checkstyle

e52107e

Modify export command to allow users to define their own file to expo…

27030ef

…rt to. Command: export <file name>

Modify deadline formatting in export command to better interpret star…

bf7f7b6

…t date and end date.

Added history tracking for current session for text field to make it …

3d4adeb

…closer to a command line!

extended TaskScheduleCommand to accomodate no deadline inputs

dc42ef9

extended ScheduleParser to accomodate no deadline inputs

566f0e4

Merge pull request #143 from TanYiXiang/B-RefactorPostpone

3482cb8

B refactor postpone

Schedule command bugfix

e4efa55

javadoc

4efecb8

Implemented basic Storage Junit test. Will add more later.

b1fc032

Refactor postpone command and add test for clash.

f6c3678

First version of history for input text.

57d5866

Completed Command line functionality - up to see prev dwn to see next!

aa2c643

Merge https://github.com/AY1920S1-CS2113-T13-3/main

38860a7

# Conflicts: # src/main/java/chronologer/command/ExportCommand.java

Merge pull request #155 from E0310898/master

5014208

Implemented a history like feature for the chatbot.

Merge branch 'master' into B-ModifyIcs

1cb8647

Modified export command to include flags to extract certain type of t…

7e1e3c8

…asks

TanYiXiang and others added 29 commits November 11, 2019 17:27

Add Junit test for edit parser

c5e37fb

Added priority parser

4f722b3

Minor checkstyle fix

5e79820

Added and updated test cases, fixed a bug with week command.

656be30

Merge https://github.com/AY1920S1-CS2113-T13-3/main

4d030fc

Merge pull request #208 from TanYiXiang/B-ParserTest

0d04aa4

B parser test

Updated theme tes, corrected reminder test and reminder

abdcea4

Merge https://github.com/AY1920S1-CS2113-T13-3/main

2fc30e1

Cleaned up, hopefully last PR!

d3562e6

Cleared checkstyle.

97f6ace

Changed to test based on duration issue. reverted Reminder to origina…

076b169

…l state.

Merge pull request #209 from E0310898/master

6aa1e28

Added test cases and did quite a few bug fixes.

minor quality edit

8c4b3bc

Merge pull request #211 from fauzt/master

5a2807a

minor quality edit

updated ui.png

e0e5280

adding commands for testing purpose

ec80428

Merge pull request #212 from hanskw4267/master

2bffad5

updated ui.png

Merge pull request #213 from fauzt/master

f0a7bec

added commands for testing purpose

Update AboutUs.adoc

570e3ab

Update AboutUs.adoc

8c4c44e

Update AboutUs.adoc

4e591b7

Update UserGuide.adoc

7b70cd8

Update AboutUs.adoc

ce04338

Update AboutUs.adoc

3d7789e

Update AboutUs.adoc

eca91d9

Update AboutUs.adoc

4c2b58b

docs update, as suggested by module lead

b0b323b

cleanup to eliminate confusion

c2f670e

Merge pull request #215 from fauzt/master

5e94373

DG & UG update after module lead approval.

nishanthelango pushed a commit to nishanthelango/Duchess that referenced this pull request Nov 23, 2021

update user guide and readme (nusCS2113-AY1920S1#34)

a557c36

* test * test * test * test * test * test * test * image * image * image * image * update * update * update * update * update

Conversation

hanskw4267 commented Sep 11, 2019

Uh oh!

RubaP left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants