fix so that commands with && > | these operator work #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euforia
requested changes
Oct 26, 2023
Collaborator
euforia
left a comment
euforia
left a comment
There was a problem hiding this comment.
Allowing pipes and redirects is a larger concern
Member
Author
|
Yeah we need these when we need to append to a file like we needed in next.conf.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if we had to run commad like
echo "/** @type {import('next').NextConfig} */" > next.config.jsorcd project && npm ithese won't work as exec.Command does not store standard output or standard err it a command fail it simply retuns an error thus causing us problem with yml files where we need to do custom nginx file addition or configuration file changes.
fix is to treat each command as a bash command as whole.