Imporved cli instructions and a feat to take ssh passphrase if any #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
euforia
requested changes
Oct 25, 2023
| if strings.Contains(err.Error(), ".ssh: no such file or directory") { | ||
| return &SSHKeys{dir: "", keys: nil} | ||
| } | ||
| panic(err) |
Collaborator
There was a problem hiding this comment.
We should just log this as error and return &SSHKeys{keys:[]string{}}
Member
Author
There was a problem hiding this comment.
yeah this gets logged to the cli we already have that logic in cli.go file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially we had template create cmd as
jumpstart -t [template name] {project name}but on the other hand we have the concept of sub commands as well likejumpstart template listso I thought of a different approach to make command more declarative by going with optionjumpstart create -t [template name ] {project name}when we create a ssh key for github ir prompts user to enter a phassphrase to encrypt the RSA key. previously it was hardcoded in the code now we are taking that input from the user on line no 112 to 114 in cli.go file
if .ssh folder does not exist in home directory we are not going for a panic now instead we return an empty instance of SSHKeys so that user knows that github ssh is not setup and he need to do it .