Skip to content

[FIX] Hugely degraded performance for the translation subquery inject… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 4 commits into
base: 10.0
Choose a base branch
from
Open

[FIX] Hugely degraded performance for the translation subquery inject… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
638ecca
[FIX] Hugely degraded performance for the translation subquery inject…
eantones Jun 23, 2018
4e19dd0
[FIX] base: create index as unique and remove duplicates before
FFernandez-PlanetaTIC Dec 20, 2019
791aae0
[FIX] base: Make it compatible with all versions of PostgreSQL suppor…
eantones Jan 15, 2020
c6f6854
[FIX] base: Fix issues importing translations
eantones Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions odoo/addons/base/ir/ir_translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,18 @@ def finish(self):
(tuple(src_relevant_fields), tuple(src_relevant_fields)))

# Step 3: insert new translations
cr.execute(""" INSERT INTO %s(name, lang, res_id, src, type, value, module, state, comments)
cr.execute(""" INSERT INTO %(_model_table)s(name, lang, res_id, src, type, value, module, state, comments)
SELECT name, lang, res_id, src, type, value, module, state, comments
FROM %s AS ti
WHERE NOT EXISTS(SELECT 1 FROM ONLY %s AS irt WHERE %s);
""" % (self._model_table, self._table, self._model_table, find_expr),
FROM %(_table)s AS ti
WHERE NOT EXISTS(SELECT 1 FROM ONLY %(_model_table)s AS irt WHERE %(find_expr)s) AND
NOT EXISTS(SELECT 1 FROM ONLY %(_model_table)s AS irt
WHERE (irt.type, irt.name, irt.lang, irt.res_id, md5(irt.src)) =
(ti.type, ti.name, ti.lang, ti.res_id, md5(ti.src))) AND
NOT EXISTS(SELECT 1 FROM %(_table)s AS tj
WHERE (tj.type, tj.name, tj.lang, tj.res_id, md5(tj.src)) =
(ti.type, ti.name, ti.lang, ti.res_id, md5(ti.src)) AND
tj.id > ti.id);
""" % dict(_model_table=self._model_table, _table=self._table, find_expr=find_expr),
(tuple(src_relevant_fields), tuple(src_relevant_fields)))

if self._debug:
Expand Down Expand Up @@ -281,8 +288,18 @@ def _auto_init(self):
cr.execute('CREATE INDEX ir_translation_src_md5 ON ir_translation (md5(src))')
cr.commit()

if 'ir_translation_ltn' not in indexes:
cr.execute('CREATE INDEX ir_translation_ltn ON ir_translation (name, lang, type)')
if 'ir_translation_unique' not in indexes:
# remove duplicated translations before unique index creation
cr.execute('''
DELETE FROM ir_translation t
USING (SELECT type, name, lang, res_id, md5(src) AS md5_src, max(id) AS max_id
FROM ir_translation
GROUP BY type, name, lang, res_id, md5(src)
HAVING COUNT(id) > 1) dup
WHERE (t.type, t.name, t.lang, t.res_id, md5(t.src)) = (dup.type, dup.name, dup.lang, dup.res_id, dup.md5_src)
AND t.id <> dup.max_id
''')
cr.execute('CREATE UNIQUE INDEX ir_translation_unique ON ir_translation (type, name, lang, res_id, md5(src))')
cr.commit()
return res

Expand Down
8 changes: 3 additions & 5 deletions odoo/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4151,16 +4151,14 @@ def _generate_translated_field(self, table_alias, field, query):
# The parenthesis surrounding the select are important, as this is a sub-select.
# The quotes surrounding `ir_translation` are important as well.
unique_translation_subselect = """
(SELECT DISTINCT ON (res_id) res_id, value
FROM "ir_translation"
WHERE name=%s AND lang=%s AND value!=%s
ORDER BY res_id, id DESC)
(SELECT res_id, value FROM "ir_translation"
WHERE name=%s AND lang=%s AND value!='')
"""
alias, alias_statement = query.add_join(
(table_alias, unique_translation_subselect, 'id', 'res_id', field),
implicit=False,
outer=True,
extra_params=["%s,%s" % (self._name, field), self.env.lang, ""],
extra_params=["%s,%s" % (self._name, field), self.env.lang],
)
return 'COALESCE("%s"."%s", "%s"."%s")' % (alias, 'value', table_alias, field)
else:
Expand Down