Open
Conversation
bjkumal
force-pushed
the
16.0-imp-lighting_vertical
branch
2 times, most recently
from
0b26efa to
aaafe66
Compare
eantones
requested changes
May 26, 2025
Member
eantones
left a comment
eantones
left a comment
There was a problem hiding this comment.
You forgot the translations. Please check this commit out. I modified just the lighting module, please take this as an example to do the same in the other modules. We can discuss if you have doubts when a field string is duplicated.
eantones
force-pushed
the
16.0-imp-lighting_vertical
branch
from
d800adb to
41623e9
Compare
bjkumal
force-pushed
the
16.0-imp-lighting_vertical
branch
from
41623e9 to
9dee588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.