Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 2, 2025

This PR updates the outdated androidx.window:window dependency from version 1.0.0-alpha09 to 1.2.0 to address a security/quality issue identified for app version 1011.

Problem

The app was using an outdated SDK version of androidx.window:window (1.0.0-alpha09) as a transitive dependency from the @numbersprotocol/preview-camera plugin. The dependency maintainers recommend updating to version 1.0.0-beta04 or later.

Solution

Added an explicit dependency override in the Android build configuration to force the use of version 1.2.0, which is a stable release that meets the recommended version requirement.

Changes Made

  • Added androidxWindowVersion = '1.2.0' to android/variables.gradle
  • Added explicit dependency implementation "androidx.window:window:$androidxWindowVersion" to android/app/build.gradle
  • Included explanatory comment identifying the source of the outdated dependency

Technical Details

The outdated dependency was located in:

node_modules/@numbersprotocol/preview-camera/android/build.gradle:95
implementation 'androidx.window:window:1.0.0-alpha09'

By adding an explicit dependency declaration in the main app's build.gradle, Gradle's dependency resolution will use the newer version (1.2.0) instead of the outdated transitive dependency (1.0.0-alpha09).

This approach follows the project's existing pattern of managing dependency versions through variables defined in variables.gradle.

Fixes #3340.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx1536m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.11.1-all/2qik7nd48slq1ooc2496ixf4i/gradle-8.11.1/lib/gradle-daemon-main-8.11.1.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.11.1-all/2qik7nd48slq1ooc2496ixf4i/gradle-8.11.1/lib/agents/gradle-instrumentation-agent-8.11.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.11.1 (dns block)
  • npm.pqina.nl
    • Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] [Quality/Improve] Updating an outdated SDK version of androidx.window:window Update androidx.window:window dependency from 1.0.0-alpha09 to 1.2.0 Jun 2, 2025
Copilot AI requested a review from numbers-official June 2, 2025 06:31
@numbers-official numbers-official requested review from olgahaha and removed request for numbers-official June 3, 2025 11:01
Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com>
@olgahaha olgahaha marked this pull request as ready for review August 4, 2025 06:08
@olgahaha olgahaha merged commit fde6f9d into main Aug 4, 2025
11 checks passed
@olgahaha olgahaha deleted the copilot/fix-3340 branch August 4, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Quality/Improve] Updating an outdated SDK version of androidx.window:window

3 participants