Fix Incorrect Asset Date When Viewing Restored Data Offline

[Copilot]

Problem

When the app is in offline mode and users view restored assets, the displayed dates are incorrect. This issue only occurs in offline mode and creates confusion for users who need accurate timestamps.

Root Cause

The uploadedAtOrTimestamp getter in the Proof class was using string length to determine if a timestamp was in milliseconds or seconds format:

// Old implementation
const proofTimestampInMilliseconds =
  this.timestamp.toString().length === LENGTH_IN_MILLISECONDS
    ? this.timestamp
    : this.timestamp * MILLISECONDS_PER_SECOND;

This approach is unreliable when handling timestamps from restored data, especially when offline.

Solution

Implemented a more robust threshold-based approach to detect if a timestamp is in milliseconds or seconds:

// New implementation
const MILLISECONDS_THRESHOLD = 10000000000; // 10^10, timestamps after March 2001
const proofTimestampInMilliseconds =
  this.timestamp > MILLISECONDS_THRESHOLD
    ? this.timestamp
    : this.timestamp * MILLISECONDS_PER_SECOND;

This approach is more reliable because:

1. It checks the numerical value instead of string length
2. The threshold (10^10) correctly differentiates between seconds and milliseconds for any date after March 2001
3. It works consistently regardless of network status

Changes

1. Replaced string length check with threshold-based detection in uploadedAtOrTimestamp getter
2. Updated documentation to reflect the new approach
3. Added entry to CHANGELOG.md

Fixes #3336.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• npm.pqina.nl
  • Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR fixes an issue with incorrect asset date display in offline mode by replacing the unreliable string length check with a threshold-based approach in the timestamp getter within the Proof class.

• Replaces a string-length check with numerical threshold logic.
• Updates inline documentation and changelog to reflect the new approach.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/app/shared/repositories/proof/proof.ts	Updates the logic in the timestamp getter to use a threshold-based approach and revises documentation comments.
CHANGELOG.md	Adds an entry referencing the fix for incorrect asset date display (fixes #3336).

[Copilot]

If this threshold logic is or may be reused elsewhere, consider extracting MILLISECONDS_THRESHOLD into a shared constants file for improved maintainability.

[olgahaha]

This PR doesn’t address the root issue and should be revised.

[Copilot]

This PR doesn’t address the root issue and should be revised.

I've revised the PR to address the root issue. The previous approach only fixed the timestamp conversion in the uploadedAtOrTimestamp getter, but not in the timestamp getter itself, which is used directly in other parts of the code like the information page.

The new solution modifies the timestamp getter to ensure all timestamps are consistently in milliseconds format, regardless of whether they come from restored data or not. This ensures correct date display in all cases, including offline mode. The fix is applied in commit 3b81985.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• npm.pqina.nl
  • Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[olgahaha]

Fix Codacy Static Code Analysis

[olgahaha]

Fix Codacy Static Code Analysis
Check notice on line 76 in src/app/shared/repositories/proof/proof.ts

@codacy-production
codacy-production
/ Codacy Static Code Analysis

src/app/shared/repositories/proof/proof.ts#L76
This line has a length of 110. Maximum allowed is 100.

[olgahaha]

there's also npm run lint error. fix it
Checking formatting...
[warn] src/app/shared/repositories/proof/proof.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

[olgahaha]

@copilot Fix Codacy Static Code Analysis
Check notice on line 76 in src/app/shared/repositories/proof/proof.ts

@codacy-production
codacy-production
/ Codacy Static Code Analysis

src/app/shared/repositories/proof/proof.ts#L76
This line has a length of 110. Maximum allowed is 100.

there's also npm run lint error. fix it
Checking formatting...
[warn] src/app/shared/repositories/proof/proof.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?