Fix CommodityClassification reader to support CommodityCode element#167
Merged
Fix CommodityClassification reader to support CommodityCode element#167
Conversation
The UBL CommodityClassification can contain either ItemClassificationCode or CommodityCode. The reader only looked for ItemClassificationCode, causing warnings when parsing XML files that use CommodityCode instead. This fix: - Adds fallback to CommodityCode when ItemClassificationCode is not found - Adds null-check to prevent warnings when neither element is present - Adds null-coalescing for the value to handle edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommodityCodeinstead ofItemClassificationCodeCommodityClassificationelement can contain eitherItemClassificationCodeorCommodityCode, but the reader only supported the formerChanges
CommodityCodewhenItemClassificationCodeis not foundTest plan
CommodityCodeelementsCommodityCodevalues are correctly extracted