Conversation
Add support for UBL 2.1 DebitNote documents, similar to existing CreditNote support. DebitNote differs from Invoice/CreditNote in that: - It has no TypeCode element - Uses RequestedMonetaryTotal instead of LegalMonetaryTotal - Uses DebitedQuantity instead of InvoicedQuantity New files: - src/DebitNote.php - DebitNote class extending Invoice - src/DebitNoteLine.php - DebitNoteLine class extending InvoiceLine - tests/Write/SimpleDebitNoteTest.php - Test for writing DebitNote Modified files: - src/Invoice.php - Add conditional logic for DebitNote specifics - src/InvoiceLine.php - Add DebitedQuantity support - src/Generator.php - Add debitNote() method - src/Reader.php - Add DebitNote deserializer mappings - src/Schema.php - Add DEBITNOTE constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./vendor/bin/phpunit tests/Write/SimpleDebitNoteTest.php- validates against UBL 2.1 schema./vendor/bin/phpunit- all 31 tests pass