Fix TypeError: Change setter types to nullable for reference classes

changelog/next-release.md

@@ -0,0 +1,9 @@
+# Next release
+
+## Fixed
+
+- Fix TypeError: Change setter types to nullable in reference classes to handle empty XML elements gracefully during parsing
+  - `OrderReference::setId()` now accepts `?string`
+  - `ProjectReference::setId()` now accepts `?string`
+  - `ContractDocumentReference::setId()` now accepts `?string`
+  - `InvoiceDocumentReference::setOriginalInvoiceId()` now accepts `?string`

src/ContractDocumentReference.php

@@ -14,18 +14,18 @@ class ContractDocumentReference implements XmlSerializable, XmlDeserializable
     private $id;
 
     /**
-     * @return string
+     * @return string|null
      */
-    public function getId(): string
+    public function getId(): ?string
     {
         return $this->id;
     }
 
     /**
-     * @param string $id
+     * @param string|null $id
      * @return static
      */
-    public function setId(string $id)
+    public function setId(?string $id)
     {
         $this->id = $id;
         return $this;

src/InvoiceDocumentReference.php

@@ -28,9 +28,10 @@ public function getOriginalInvoiceId(): ?string
     /**
      * Set the id of the invoice that is being credited
      *
+     * @param string|null $invoiceRef
      * @return static
      */
-    public function setOriginalInvoiceId(string $invoiceRef)
+    public function setOriginalInvoiceId(?string $invoiceRef)
     {
         $this->originalInvoiceId = $invoiceRef;
         return $this;

src/OrderReference.php

@@ -19,18 +19,18 @@ class OrderReference implements XmlSerializable, XmlDeserializable
     private $issueDate;
 
     /**
-     * @return string
+     * @return string|null
      */
-    public function getId(): string
+    public function getId(): ?string
     {
         return $this->id;
     }
 
     /**
-     * @param string $id
+     * @param string|null $id
      * @return static
      */
-    public function setId(string $id)
+    public function setId(?string $id)
     {
         $this->id = $id;
         return $this;

src/ProjectReference.php

@@ -14,18 +14,18 @@ class ProjectReference implements XmlSerializable, XmlDeserializable
     private $id;
 
     /**
-     * @return string
+     * @return string|null
      */
-    public function getId(): string
+    public function getId(): ?string
     {
         return $this->id;
     }
 
     /**
-     * @param string $id
+     * @param string|null $id
      * @return ProjectReference
      */
-    public function setId(string $id): ProjectReference
+    public function setId(?string $id): ProjectReference
     {
         $this->id = $id;
         return $this;