Implement basic LRCLIB lyrics provider#122
Draft
maxmitti wants to merge 3 commits intonullobsi:mainfrom
Draft
Conversation
Owner
|
the approach is good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very basic implementation for fetching lyrics from https://lrclib.net.
The extraction of the base class
LyricsProviderfromUltimateLyricsProvideris still a bit messy.In contrast to #93 this implementation is straight forward using Qt’s JSON and HttpRequest support.
What do you think about the overall approach?
I am also uncertain about how to implement error handling within the
LyricsProvider.Closes #94