improve error handling and fix biwapp parsing error #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d remove the need for a global variable
… lost. This should also fix the issue with the broken thread-view for updated alerts as the references were lost before.
This allows for performing the self-check in the background without the need to call the self-check in a build method. This wasn't possible anymore as the appState itself moved to a provider, and we can not set a provider state in a build method.
We didn't reset the expired flag. So the place was still marked as expired even if the subscription was renewed
…or in the alertAnUpdate method for cases where the referenced alert is not in our list of alerts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes: