fix: Fix transition to thank you page without payment #67
Conversation
SCSE-196 Fix transition to thank you page without payment
Thank you page is rendered after closing the payment QR code even without payment. Frontend should validate that the order is not cancelled and not pending payment. If it is cancelled/pending payment, do not show the "Thank You" text. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This change can be validated in the preview deployment: https://fe-git-fix-scse-196-cse-it.vercel.app/order-summary/3fcd576f-2122-4fe1-9f4a-392441d1632f Payment completed: https://fe-git-fix-scse-196-cse-it.vercel.app/order-summary/f5879f91-021a-433e-ad7f-a03ed5c67125 |
chanbakjsd
force-pushed
the
fix/SCSE-196
branch
from
cb07785 to
bbb67ac
Compare
chanbakjsd
force-pushed
the
fix/SCSE-196
branch
from
bbb67ac to
f282b19
Compare
YoNG-Zaii
left a comment
YoNG-Zaii
left a comment
There was a problem hiding this comment.
In the Payment Pending page:
"We are currently pending confirmation for your payment from our payment processor. If you have paid, please check back later.
Should the issue persist, please contact us at merch@ntuscse.com with proof of payment. We apologize for the inconvenience."
I believe the line spacing between the two sentences can be smaller. The button 'continue spacing' can have more top margin.
In Stripe, some payment methods (in our case PayNow) may redirect back to the `return_url` and the PaymentIntent will have a status of `requires_payment_method`. In this case, we should attempt to recollect payment from the user. [SCSE-196]
chanbakjsd
force-pushed
the
fix/SCSE-196
branch
from
f282b19 to
9c821c7
Compare
|
@YoNG-Zaii The issue pointed out has been fixed. |
YoNG-Zaii
left a comment
YoNG-Zaii
left a comment
There was a problem hiding this comment.
LGTM in terms of payment pending page.
This PR should address the issue of transitioning to thank you page by checking a special case for Stripe.
In addition, the order summary page now shows "Payment Pending" in case the user did get redirected for whatever reason.
[SCSE-196]