Open
Conversation
yuki-uchida
reviewed
Feb 9, 2026
| publishers: tokio::sync::Mutex<HashMap<SessionId, Arc<dyn Publisher>>>, | ||
| sessions: DashMap<SessionId, Arc<dyn Session>>, | ||
| publishers: DashMap<SessionId, Arc<dyn Publisher>>, | ||
| subscriber_repo: SubscriberRepository, |
Collaborator
There was a problem hiding this comment.
構造体がpublishersと異なるので合わせて欲しい
| @@ -14,17 +13,17 @@ use crate::modules::{ | |||
|
|
|||
| pub(crate) struct SessionRepository { | |||
| thread_manager: ThreadManager, | |||
| sessions: tokio::sync::Mutex<HashMap<SessionId, Arc<dyn Session>>>, | |||
| publishers: tokio::sync::Mutex<HashMap<SessionId, Arc<dyn Publisher>>>, | |||
| sessions: DashMap<SessionId, Arc<dyn Session>>, | |||
Collaborator
There was a problem hiding this comment.
sessionsとpublishers/subscribersは親子関係だからまとめられないか整理してほしい
Collaborator
Author
There was a problem hiding this comment.
sessionのみを管理するようにしました
addの時点で生成して個別に管理する必要は特にないかなという判断をしました
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PUBLISH/SUBSCRIBEを実装