Replace sprintf with snprintf in refclock_ripencc logging#26
Open
kodareef5 wants to merge 1 commit intontp-project:stablefrom
Open
Replace sprintf with snprintf in refclock_ripencc logging#26kodareef5 wants to merge 1 commit intontp-project:stablefrom
kodareef5 wants to merge 1 commit intontp-project:stablefrom
Conversation
Four sprintf calls write formatted GPS receiver data into a 1024-byte logbuf without bounds checking. The C1 format string at line 1677 has 17 format specifiers including floating-point values that can produce long output. Replace with snprintf bounded by sizeof(logbuf).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four sprintf calls in ntpd/refclock_ripencc.c write formatted GPS receiver data into a 1024-byte logbuf without bounds checking. The C1 format string has 17 format specifiers including floating-point values. Replace with snprintf bounded by sizeof(logbuf).