Feat/meta data native contract #3759

carpawell · 2025-12-26T08:53:59Z

Contract part of #3742.

cthulhu-rider

rebase is needed

cthulhu-rider · 2025-12-26T10:25:08Z

pkg/innerring/internal/metachain/contracts.go

+			panic(fmt.Sprintf("unexpected native contract found: %T", contract))
+		}
+	}
+	return append(newContracts, meta.NewMetadata(neoContract))


meta.NewMetadata does not seem resistant to nil arg. I'd precheck it

in general, looking at for-loop, we dont check absence of any contract. If they are required, i'd still prevent this

added required contracts checks to NewCustomNatives

cthulhu-rider · 2025-12-26T10:28:34Z

pkg/innerring/internal/metachain/contracts.go

+			newContracts = append(newContracts, contract)
+		case *native.Std, *native.Crypto, *native.Oracle, *native.Treasury:
+		default:
+			panic(fmt.Sprintf("unexpected native contract found: %T", contract))


is this done to not miss new contract?

since native.NewDefaultContracts does not state there will be no more contract, i'd say this is an error

A new contract is a significant (and very rare) event, this forces explicit handling of it. Should be ok.

is this done to not miss new contract?

yes, *native.Treasury was even added after this feature was started to be implemented. my idea was that once there is an update in neo-go, tests will start panicking, and we will immediately find out whether we need to adopt a new contract to our side chain or not

cthulhu-rider · 2025-12-29T10:05:49Z

pkg/innerring/internal/metachain/gas/gas.go

+	g := &GAS{
+		initialSupply: init,
+	}
+	defer g.BuildHFSpecificMD(g.ActiveIn())


defer seems redundant

this is the way every native contract is implemented in neo-go, so i suggest to keep it

cthulhu-rider · 2025-12-29T10:09:54Z

pkg/innerring/internal/metachain/contracts/gas/gas.go

+	return nil
+}
+
+// InitializeCache implements the Contract interface.


Suggested change

// InitializeCache implements the Contract interface.

// InitializeCache implements [native.IGAS] interface.

for all methods

cthulhu-rider · 2025-12-29T10:19:08Z

pkg/innerring/internal/metachain/contracts/gas/nep17.go

+}
+
+// makeUint160Key creates a key from the account script hash.
+func makeUint160Key(prefix byte, h util.Uint160) []byte {


unused too? Seems like some stuff is copy-pasted but not needed

cthulhu-rider · 2025-12-29T10:32:41Z

pkg/innerring/internal/metachain/meta/method_netmap.go

+			return fmt.Errorf("%d vector has incorrect REP: %w", i, err)
+		}
+		rep := repB.Int64()
+		if rep > maxREPsClauses {


i'd also check negatives

cthulhu-rider · 2025-12-29T10:36:48Z

pkg/innerring/internal/metachain/meta/method_netmap.go

+	Nodes keys.PublicKeys
+}
+
+func (p Placement) ToStackItem() (stackitem.Item, error) {


used anywhere?

for some reason lost resolution for this thread: #3742 (comment)

is used now

cthulhu-rider · 2025-12-29T10:38:34Z

pkg/innerring/internal/metachain/contracts/meta/method_objects.go

+	}
+	metaInfo, ok := metaInfoSI.Value().([]stackitem.MapElement)
+	if !ok {
+		panic(fmt.Errorf("unexpected deserialized meta information value: expected %T, %T, given", metaInfo, metaInfoSI.Value()))


Suggested change

panic(fmt.Errorf("unexpected deserialized meta information value: expected %T, %T, given", metaInfo, metaInfoSI.Value()))

panic(fmt.Errorf("unexpected deserialized meta information value: expected %T, %T given", metaInfo, metaInfoSI.Value()))

cthulhu-rider · 2025-12-29T10:46:25Z

pkg/innerring/internal/metachain/contracts/meta/method_objects.go

+		}
+
+		if foundSigs == rep {
+			continue nodesLoop


instruction seems excessive here, condition may be inverted

reimplementation of the byte-contract code from the neofs-contracts problems. fixed

cthulhu-rider · 2025-12-29T10:47:59Z

pkg/innerring/internal/metachain/contracts/meta/method_objects.go

+		panic("incorrect vub")
+	}
+	if vub.Int64() <= int64(ic.BlockHeight()) {
+		panic("incorrect vub: exceeded")


runtime values may be helpful in exception

added values everywhere a value is parsed and can be stringified

roman-khimov · 2025-12-30T10:23:34Z

pkg/innerring/internal/metachain/contracts/contracts.go

@@ -0,0 +1,45 @@
+package contracts


I'd strip this directory, can be metachain.

roman-khimov · 2025-12-30T10:27:39Z

pkg/innerring/internal/metachain/contracts.go

+			newContracts = append(newContracts, contract)
+		case *native.Std, *native.Crypto, *native.Oracle, *native.Treasury:
+		default:
+			panic(fmt.Sprintf("unexpected native contract found: %T", contract))


A new contract is a significant (and very rare) event, this forces explicit handling of it. Should be ok.

roman-khimov · 2025-12-30T10:30:18Z

pkg/innerring/internal/metachain/gas/nep17.go

+)
+
+// nep17TokenNative represents a NEP-17 token contract.
+type nep17TokenNative struct {


Wow. This should be imported from NeoGo native, really.

really sorry, but it is not now

roman-khimov · 2025-12-30T15:29:17Z

pkg/innerring/internal/metachain/contracts/meta/meta.go

+	m.AddMethod(md, desc)
+
+	desc = native.NewDescriptor("registerMetaContainer", smartcontract.VoidType,
+		manifest.NewParameter("cID", smartcontract.Hash256Type))


roman-khimov · 2025-12-30T15:29:27Z

pkg/innerring/internal/metachain/contracts/meta/meta.go

+	m.AddMethod(md, desc)
+
+	desc = native.NewDescriptor("unregisterMetaContainer", smartcontract.VoidType,
+		manifest.NewParameter("cID", smartcontract.Hash256Type))


Here as well.

roman-khimov · 2025-12-30T16:17:17Z

pkg/innerring/internal/metachain/meta/method_objects.go

+		panic("container does not support chained metadata")
+	}
+
+	sigsVectorsRaw, ok := args[1].Value().([]stackitem.Item)


This follows current container contract, but eventually it can be removed from parameters, nodes can sign transaction directly.

this will require responding there with a signature not of an object's metadata, but with a signature of some predefined transaction. is that what you meant?

Yes. Another option is a custom verification callback.

roman-khimov · 2025-12-30T16:29:31Z

pkg/innerring/internal/metachain/meta/method_objects.go

+		}
+	}
+
+	// required


Why cid is checked separately?

it is used in other checks above (container must exist and be registered as one that supports meta)

I'd rather have similar checks at the same place.

roman-khimov · 2025-12-30T16:31:37Z

pkg/innerring/internal/metachain/meta/method_objects.go

+
+		for _, sig := range sigVectors[i] {
+			for _, node := range placement[i].Nodes {
+				if node.Verify(sig, metaHash) {


i only suggest sorting signatures by public keys. requires support on the IR side and on the SN side

It's not just about sorting. Remember, currently signatures are verified in verify() method of Proxy contract. This scales well. Checking them during transaction execution doesn't.

But sorting is beneficial anyway and easily done.

roman-khimov · 2025-12-30T16:33:32Z

pkg/innerring/internal/metachain/contracts/meta/method_objects.go

+	}
+	if v, ok := getFromMap(metaInfo, "firstPart"); ok {
+		firstPart, err := v.TryBytes()
+		if err != nil || len(firstPart) != smartcontract.Hash256Len {


sha256 extraction is pretty popular

roman-khimov · 2025-12-30T16:34:59Z

pkg/innerring/internal/metachain/meta/method_objects.go

+	if err != nil {
+		panic(err)
+	}
+


That's it, no processing?

do you mean the secondary index must be in the same chain? my first implementation only needs side chain to check metadata and then notify about it. all the storage nodes handle notification on their own

Among things current structure tries to solve is state synchronization. There is everything needed for it in blockchain, but if you're just throwing an event it all doesn't work. Primary index (based on submitted data) must be built directly on-chain. Then seconday one (header-based) is a different story.

codecov · 2025-12-30T17:34:03Z

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.74%. Comparing base (97f9696) to head (1f840ee).

Files with missing lines	Patch %	Lines
pkg/innerring/internal/metachain/contracts.go	0.00%	30 Missing ⚠️
pkg/innerring/internal/blockchain/blockchain.go	0.00%	2 Missing ⚠️
pkg/innerring/internal/metachain/chain.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
- Coverage   25.77%   25.74%   -0.03%     
==========================================
  Files         657      659       +2     
  Lines       42163    42195      +32     
==========================================
- Hits        10867    10863       -4     
- Misses      30308    30344      +36     
  Partials      988      988

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Also, implement new MetaData contract and GAS contract implementation without economic. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>

carpawell requested a review from AnnaShaleva December 26, 2025 08:53

carpawell requested review from End-rey, cthulhu-rider and roman-khimov as code owners December 26, 2025 08:54

cthulhu-rider reviewed Dec 29, 2025

View reviewed changes

roman-khimov reviewed Dec 30, 2025

View reviewed changes

carpawell force-pushed the feat/meta-data-native-contract branch 2 times, most recently from bd68082 to c8ae0ca Compare December 30, 2025 17:31

ir/internal: add possibility to deploy custom native contract

1f840ee

Also, implement new MetaData contract and GAS contract implementation without economic. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>

carpawell force-pushed the feat/meta-data-native-contract branch from c8ae0ca to 1f840ee Compare December 30, 2025 17:36

	// InitializeCache implements the Contract interface.
	// InitializeCache implements [native.IGAS] interface.

	panic(fmt.Errorf("unexpected deserialized meta information value: expected %T, %T, given", metaInfo, metaInfoSI.Value()))
	panic(fmt.Errorf("unexpected deserialized meta information value: expected %T, %T given", metaInfo, metaInfoSI.Value()))

Feat/meta data native contract #3759

Are you sure you want to change the base?

Feat/meta data native contract #3759

Uh oh!

Conversation

carpawell commented Dec 26, 2025

Uh oh!

cthulhu-rider left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 30, 2025 •

edited

Loading