Autocreate css directory if it's missing#10
Open
labeneator wants to merge 3 commits intonsonnad:masterfrom
Open
Autocreate css directory if it's missing#10labeneator wants to merge 3 commits intonsonnad:masterfrom
labeneator wants to merge 3 commits intonsonnad:masterfrom
Conversation
Autocreate static directory if it's not there.
Remove my prompt.
lzzzfelipe
reviewed
Oct 13, 2016
README.md
Outdated
|
|
||
| ```sh | ||
| wget -O `ipython locate profile <profile-name>`/static/custom/custom.css | ||
| mkdir -p `ipython locate profile default`/static/custom/; wget -O `ipython locate profile <profile-name>`/static/custom/custom.css |
There was a problem hiding this comment.
For consistency, it should be <profile-name> instead of default.
Author
|
Ack. Since there isn't a way of figuring out the profile-name, I'll retract this PR. |
Author
|
oops, disregard my previous comment. Reopening with the proposed fix |
Bug fix for hard-coded profile-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdir -p the css directory for an even easier installation example