Fix findResources when path ends with slash#47
Open
melix wants to merge 1 commit intonsoft:masterfrom
Open
Conversation
This commit fixes the `findResources` method, which failed to find resources when the resource name ended with a `/`, which is inconsistent with the Java classloader. This issue was discovered while evaluating Uno-Jar as a replacement for fatjar creation in Micronaut.
Author
|
I actually just realized that the jar that I modified is manually copied to the resources directory... running a Gradle task. I don't think it's a good practice to do this, I'm working on a build update to avoid this. |
Author
|
Superceded by #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the
findResourcesmethod, which failed to find resources when the resource name ended with a/, which is inconsistent with the Java classloader.This issue was discovered while evaluating Uno-Jar as a replacement for fatjar creation in Micronaut.