You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds an exponential level system
XP Gains and checks made at the end of battle
XP Gain PvP based of percent xp needed to level up and level difference between opponents
XP Gain PvE based on monster xp set
Stat growth currently randomized at 8-12% per stat (growth currently effected by items)
Currently no class system
As leveling, xp, and stat growth can play a large function is there an overall place that would be good to set those rates?
Does this sound like a generally solid rate for level growth?
Additional testing is still needed. I wanted to check on the structure of the additions before continuing.
Hi @jrambold - thank you for opening this pull request. It looks like things are off to a good start, but I'd urge you to think about/write more testing before implementing this.
As leveling, xp, and stat growth can play a large function is there an overall place that would be good to set those rates?
Those would likely be member variables of a Class in the class system, so it's fine to hard code the values on our first draft.
Does this sound like a generally solid rate for level growth?
I'm not exactly sure, but it can be updated later if need be.
The most important thing, in the long-term, will be that these rates & algorithms can be set by the user of the Goby framework via something like a Class.
Also, you will need to update the base branch of your pull request to 0.2.1 as I do not accept pull requests directly to master. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an exponential level system
XP Gains and checks made at the end of battle
XP Gain PvP based of percent xp needed to level up and level difference between opponents
XP Gain PvE based on monster xp set
Stat growth currently randomized at 8-12% per stat (growth currently effected by items)
Currently no class system
As leveling, xp, and stat growth can play a large function is there an overall place that would be good to set those rates?
Does this sound like a generally solid rate for level growth?
Additional testing is still needed. I wanted to check on the structure of the additions before continuing.