Conversation
|
Hi @pablofullana. Here are some points to resolve/consider:
Documentation looks good; it can be placed under "Internationalization". Instead of placing a link to the Thanks! |
|
Just want to let you know that you can run |
|
@nskins I'm getting a very odd behavior on that failing spec. Any insights? |
|
I ran the build locally with HEAD at this commit, and it passes. The error message at that commit says that it cannot find i18n. It sounds like there's a problem with the Gemfile, goby.gemspec, or .travis.yml. First, could you please erase those last three commits? You can do so by running: followed by to remove the uncommitted changes. Unfortunately, I don't have time right now to look at it in more detail, but please feel free to push changes and review the Travis CI builds. If any commit does not work, then please erase it since I believe the aforementioned commit is the best starting point. |
|
I believe I have fixed that issue you were struggling with in your final commits; however, this feature should work after your first 2 or 3. Not sure, but I'd be willing to merge this if we can get the build passing. |
|
Should be good to go now. |
| spec.homepage = "https://github.com/nskins/goby" | ||
| spec.license = "MIT" | ||
|
|
||
| spec.files = Dir["{lib}/**/*", "LICENSE", "README.md" ] |
There was a problem hiding this comment.
This line is redundant, it's re-specified next line down.
Pull Request Description
Addressing #105, this PR adds internationalization support via I18n, by:
en.ymlto be updated as requiredEntityclassDocumentation proposal
Updating Goby messages
As a Goby contributor
Customizing and exiting language translations:
config/localesAdding support for new language:
config/localesconfig/locales/en.ymlcontent and update as requiredAs an application developer using Goby gem
Customizing and exiting language translations:
I18n.load_path += Dir["#{File.expand_path File.dirname(__FILE__)}/.../*.yml"]Adding support for new language:
I18n.load_path += Dir["#{File.expand_path File.dirname(__FILE__)}/.../*.yml"]en.ymlcontent from Goby into that file and update as requiredI18n.locale = :esFinally, I think it would be wise (and actually make other developers life easier) if we place a link to the
en.ymlin the documentation. By doing this, they would be able to get to that file without having to browse through all the repository.