fix: add missing rubocop and cspell linters from megalinter migration #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration from megalinter to mise-based linting missed rubocop
(Ruby linting) and cspell (spell checking). This adds:
- mise tasks for rubocop and cspell
- GitHub actions for lint-rubocop and lint-cspell
- New "lint" job in check.yaml workflow
- Updated cspell config with project-specific words
- Fixed typos discovered by cspell
Co-Authored-By: Claude Code (User Settings, in: ${CLAUDE_PROJECT_DIR}) <noreply@anthropic.com>
The initial implementation incorrectly created separate workflow jobs
and GitHub Actions for rubocop and cspell. This project uses a unified
linting approach where all linters belong in the format/lint mise tasks.
Changes:
- Remove separate lint job from check.yaml workflow
- Remove unnecessary lint-rubocop and lint-cspell actions
- Remove standalone rubocop and cspell mise tasks
- Add rubocop and cspell to the existing format task (with auto-fix)
- Add rubocop and cspell to the existing lint task (check only)
- Add CLAUDE.md documenting the linting architecture
- Add .prettierignore for session-specific files
Co-Authored-By: Claude Code (User Settings, in: ${CLAUDE_PROJECT_DIR}) <noreply@anthropic.com>
Move project-specific words from .cspell.json inline array to a
dedicated dictionary file at .config/cspell/project.txt for better
organization and maintainability.
- Add exception to .gitignore for .config/cspell/
Co-Authored-By: Claude Code (User Settings, in: ${CLAUDE_PROJECT_DIR}) <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added rubocop (Ruby linting) and cspell (spell checking) that were missed during the megalinter migration, integrating them into the existing
formatandlintmise tasks.Changes
mise.toml: Added ruby, gem:rubocop, and npm:cspell tools.mise/tasks/format: Added rubocop -A (auto-fix) and cspell.mise/tasks/lint: Added rubocop and cspell (check only).cspell.json: Added project-specific words and ignore paths.prettierignore: Added to ignore session-specific Claude filesCLAUDE.md: Added project rules documenting the linting architectureCasks/nsheaps-base.rb: Fixed typo (generage→generate)README.md: Fixed typos (referece→reference, depdendency→dependency)Architecture Note
This project uses a unified linting approach - all linters run through
mise run format(which the CI workflow calls). Security linters are the exception and use separate actions because they have different concerns.Test plan
mise exec -- rubocoplocally - passes (11 files, no offenses)mise exec -- cspell "**/*" --no-progresslocally - passes (12 files, 0 issues)🤖 Generated with Claude Code