Handle variadic functions and return values #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-uhl
commented
Jul 27, 2017
| Tcl_SetResult(interp, result, free_string); | ||
| } | ||
|
|
||
| void _gotk_c_tcl_set_obj_result(Tcl_Interp *interp, Tcl_Obj *result) { |
Author
There was a problem hiding this comment.
This is used to return a TCL object.
robert-uhl
commented
Jul 27, 2017
|
|
||
| func go_value_to_tcl_obj(value interface{}) *C.Tcl_Obj { | ||
| v := reflect.ValueOf(value) | ||
| func go_value_to_tcl_obj(v reflect.Value) *C.Tcl_Obj { |
Author
There was a problem hiding this comment.
Switched to using a reflect.Value because it better reflects usage at the existing call site and the new one.
robert-uhl
commented
Jul 27, 2017
| s := v.String() | ||
| sh := *(*reflect.StringHeader)(unsafe.Pointer(&s)) | ||
| return C.Tcl_NewStringObj((*C.char)(unsafe.Pointer(sh.Data)), C.int(len(s))) | ||
| b := C.CBytes([]byte(s)) |
Author
There was a problem hiding this comment.
Switched to this style in order to muffle linter. It does allocate more, though. Maybe it's not worth it?
robert-uhl
force-pushed
the
handle-variadic-functions-and-return-values
branch
from
94daaf3 to
2e014f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements variadic functions & return values.