reformat print line to get rid off unwanted spaces#606
Open
WardDeb wants to merge 2 commits intonservant:develfrom
Open
reformat print line to get rid off unwanted spaces#606WardDeb wants to merge 2 commits intonservant:develfrom
WardDeb wants to merge 2 commits intonservant:develfrom
Conversation
nservant
approved these changes
Jan 26, 2024
nservant
approved these changes
Jan 26, 2024
Owner
|
Hi @WardDeb |
Author
|
Thanks @nservant ! and no worries for the delay. Cheers, WardDeb |
|
I am still getting similar failure #572 even after incorporating the above changes. Kindly help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for the software !
I've noticed that the extract_snps script introduces spaces directly after the geno[1] field, at the position where the print line is split up over multiple lines. This causes issues in the assignment later on as no reads can be assigned to the alternative genotype. The pipeline fails later in the matrix generation.
Reformatting this line gets rid of the spaces and fixes the issues downstream.
I've tested with mgp_REL2021_snps.vcf.gz, corresponding to GRCm39.
Related to #572.
Kind regards,
WardDeb