Merged
Conversation
🦋 Changeset detectedLatest commit: d77f114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Terraform Plan for Stage 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.module.ssr_task.aws_ecs_task_definition.task[0] must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
~ arn = "arn:aws:ecs:eu-west-1:339713113237:task-definition/digitalekanaler-designmanual:203" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:eu-west-1:339713113237:task-definition/digitalekanaler-designmanual" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
~ image = "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:ce9b9f129930abf6d88aeaa8108cb4cc014f4570" -> "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:60ca1d9140c3c83bfed6b53a4fde610275304616"
name = "digitalekanaler-designmanual-main"
# (8 unchanged attributes hidden)
},
] # forces replacement
)
~ enable_fault_injection = false -> (known after apply)
~ id = "digitalekanaler-designmanual" -> (known after apply)
~ revision = 203 -> (known after apply)
- tags = {} -> null
# (13 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 3d8dc9f |
Contributor
Terraform Plan for Test 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.module.ssr_task.aws_ecs_task_definition.task[0] must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
~ arn = "arn:aws:ecs:eu-west-1:590183702222:task-definition/digitalekanaler-designmanual:218" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:eu-west-1:590183702222:task-definition/digitalekanaler-designmanual" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
~ image = "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:ce9b9f129930abf6d88aeaa8108cb4cc014f4570" -> "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:60ca1d9140c3c83bfed6b53a4fde610275304616"
name = "digitalekanaler-designmanual-main"
# (8 unchanged attributes hidden)
},
] # forces replacement
)
~ enable_fault_injection = false -> (known after apply)
~ id = "digitalekanaler-designmanual" -> (known after apply)
~ revision = 218 -> (known after apply)
- tags = {} -> null
# (13 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 3d8dc9f |
Contributor
Terraform Plan for Stage 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.module.ssr_task.aws_ecs_task_definition.task[0] must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
~ arn = "arn:aws:ecs:eu-west-1:339713113237:task-definition/digitalekanaler-designmanual:203" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:eu-west-1:339713113237:task-definition/digitalekanaler-designmanual" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
~ image = "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:ce9b9f129930abf6d88aeaa8108cb4cc014f4570" -> "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:60ca1d9140c3c83bfed6b53a4fde610275304616"
name = "digitalekanaler-designmanual-main"
# (8 unchanged attributes hidden)
},
] # forces replacement
)
~ enable_fault_injection = false -> (known after apply)
~ id = "digitalekanaler-designmanual" -> (known after apply)
~ revision = 203 -> (known after apply)
- tags = {} -> null
# (13 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 8d1d49d |
Contributor
Terraform Plan for Test 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.module.ssr_task.aws_ecs_task_definition.task[0] must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
~ arn = "arn:aws:ecs:eu-west-1:590183702222:task-definition/digitalekanaler-designmanual:219" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:eu-west-1:590183702222:task-definition/digitalekanaler-designmanual" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
~ image = "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:58aa240fd1f6dfdc59d7dcd31dc17556e2ce4da4" -> "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:ce9b9f129930abf6d88aeaa8108cb4cc014f4570"
name = "digitalekanaler-designmanual-main"
# (8 unchanged attributes hidden)
},
] # forces replacement
)
~ enable_fault_injection = false -> (known after apply)
~ id = "digitalekanaler-designmanual" -> (known after apply)
~ revision = 219 -> (known after apply)
- tags = {} -> null
# (13 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit 8d1d49d |
Contributor
Terraform Plan for Production 🔍Show PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.app.module.ssr_task.aws_ecs_task_definition.task[0] must be replaced
-/+ resource "aws_ecs_task_definition" "task" {
~ arn = "arn:aws:ecs:eu-west-1:471112960535:task-definition/digitalekanaler-designmanual:205" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:eu-west-1:471112960535:task-definition/digitalekanaler-designmanual" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
~ image = "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:ce9b9f129930abf6d88aeaa8108cb4cc014f4570" -> "637423315721.dkr.ecr.eu-west-1.amazonaws.com/designmanual:60ca1d9140c3c83bfed6b53a4fde610275304616"
name = "digitalekanaler-designmanual-main"
# (8 unchanged attributes hidden)
},
] # forces replacement
)
~ enable_fault_injection = false -> (known after apply)
~ id = "digitalekanaler-designmanual" -> (known after apply)
~ revision = 205 -> (known after apply)
- tags = {} -> null
# (13 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Redundant ignore_changes element
on .terraform/modules/app.preview_url/main.tf line 111, in resource "aws_lambda_function" "lambda_function":
111: resource "aws_lambda_function" "lambda_function" {
Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.
The attribute qualified_arn is decided by the provider alone and therefore
there can be no configured value to compare with. Including this attribute in
ignore_changes has no effect. Remove the attribute from ignore_changes to
quiet this warning.
(and 2 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.For commit d77f114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The new Consents & Reservations page design feature long texts in the toasts which would be prettier if a width parameter could be specified for the toasts. See the design in figma here
Solution
widthprop toToastsimilar to how theDatePickerhas implemented itOnce approved, i will add the correct documentation to the design manual
General Checklist
Accessibility checklist
For changes impacting the user interface or functionality, ensure the following:
Demonstration
toastwidth.mov